fix liveness probe removal

Author: mbaynton

pkg/reconciler/common/workload_override.go

@@ -223,7 +223,7 @@ func replaceProbes(override *base.WorkloadOverride, ps *corev1.PodTemplateSpec)
 				}
 				if *overrideProbe == (v1.Probe{}) {
 					//  Disable probe when users explicitly set the empty overrideProbe.
-					containers[i].ReadinessProbe = nil
+					containers[i].LivenessProbe = nil
 					continue
 				}
 				if containers[i].LivenessProbe == nil {

pkg/reconciler/common/workload_override_test.go

@@ -529,7 +529,7 @@ func TestComponentsTransform(t *testing.T) {
 				InitialDelaySeconds: 12,
 			}}},
 	}, {
-		name: "empty probe drops probe",
+		name: "empty readiness probe drops probe",
 		override: []base.WorkloadOverride{
 			{
 				Name: "activator",
@@ -550,6 +550,28 @@ func TestComponentsTransform(t *testing.T) {
 					}},
 			},
 		}},
+	}, {
+		name: "empty liveness probe drops probe",
+		override: []base.WorkloadOverride{
+			{
+				Name: "activator",
+				LivenessProbes: []base.ProbesRequirementsOverride{{
+					Container: "activator",
+				}}},
+		},
+		expDeployment: map[string]expDeployments{"activator": {
+			expLabels:              map[string]string{"serving.knative.dev/release": "v0.13.0"},
+			expTemplateLabels:      map[string]string{"serving.knative.dev/release": "v0.13.0", "app": "activator", "role": "activator"},
+			expTemplateAnnotations: map[string]string{"cluster-autoscaler.kubernetes.io/safe-to-evict": "false"},
+			expReplicas:            0,
+			expReadinessProbe: &v1.Probe{
+				ProbeHandler: v1.ProbeHandler{
+					HTTPGet: &v1.HTTPGetAction{
+						Port:        intstr.IntOrString{IntVal: 8012},
+						HTTPHeaders: []v1.HTTPHeader{{Name: "k-kubelet-probe", Value: "activator"}},
+					}},
+			},
+		}},
 	}, {
 		name: "neither replicas in workload override nor global replicas",
 		override: []base.WorkloadOverride{