CLN trailing compat for <3.8

Author: tomMoral

loky/backend/popen_loky_posix.py

@@ -119,7 +119,7 @@ def _launch(self, process_obj):
             reduction._mk_inheritable(child_w)
             reduction._mk_inheritable(tracker_fd)
             self._fds += [child_r, child_w, tracker_fd]
-            if sys.version_info >= (3, 8) and os.name == "posix":
+            if os.name == "posix":
                 mp_tracker_fd = prep_data["mp_tracker_args"]["fd"]
                 self.duplicate_for_child(mp_tracker_fd)
 

loky/backend/spawn.py

@@ -88,7 +88,7 @@ def get_preparation_data(name, init_main_module=True):
     else:
         d["tracker_args"]["fd"] = _resource_tracker._fd
 
-    if sys.version_info >= (3, 8) and os.name == "posix":
+    if os.name == "posix":
         # joblib/loky#242: allow loky processes to retrieve the resource
         # tracker of their parent in case the child processes depickles
         # shared_memory objects, that are still tracked by multiprocessing's

tests/_test_process_executor.py

@@ -683,9 +683,8 @@ def test_shutdown_race_issue12456(self):
         self.executor.shutdown()
 
     @pytest.mark.skipif(
-        platform.python_implementation() != "CPython"
-        or (sys.version_info >= (3, 8, 0) and sys.version_info < (3, 8, 2)),
-        reason="Underlying bug fixed upstream starting Python 3.8.2",
+        platform.python_implementation() != "CPython",
+        reason="cpython specific non-regression test (fixed starting 3.8.2)",
     )
     def test_no_stale_references(self):
         # Issue #16284: check that the executors don't unnecessarily hang onto
@@ -978,10 +977,6 @@ def test_max_depth(self, kill_workers):
         sys.maxsize < 2**32,
         reason="Test requires a 64 bit version of Python",
     )
-    @pytest.mark.skipif(
-        sys.version_info < (3, 8),
-        reason="Python version does not support pickling objects of size > 2 ** 31GB",
-    )
     def test_no_failure_on_large_data_send(self):
         data = b"\x00" * int(2.2e9)
         self.executor.submit(id, data).result()
@@ -991,10 +986,6 @@ def test_no_failure_on_large_data_send(self):
         sys.maxsize < 2**32,
         reason="Test requires a 64 bit version of Python",
     )
-    @pytest.mark.skipif(
-        sys.version_info >= (3, 8),
-        reason="Python version supports pickling objects of size > 2 ** 31GB",
-    )
     def test_expected_failure_on_large_data_send(self):
         data = b"\x00" * int(2.2e9)
         with pytest.raises(RuntimeError):

tests/test_resource_tracker.py

@@ -286,10 +286,6 @@ def test_resource_tracker_sigkill(self):
         # Uncatchable signal.
         self.check_resource_tracker_death(signal.SIGKILL, True)
 
-    @pytest.mark.skipif(
-        sys.version_info < (3, 8),
-        reason="SharedMemory introduced in Python 3.8",
-    )
     def test_loky_process_inherit_multiprocessing_resource_tracker(self):
         cmd = """if 1:
         from loky import get_reusable_executor

tests/test_reusable_executor.py

@@ -377,7 +377,6 @@ def test_crash_races(self, n_proc):
 
         if (
             sys.platform == "win32"
-            and sys.version_info >= (3, 8)
             and n_proc > 5
         ):
             pytest.skip(