Skip to content

Commit 52d1494

Browse files
committed
FIX tests reliying on child pid
1 parent 85c9aa6 commit 52d1494

File tree

1 file changed

+13
-16
lines changed

1 file changed

+13
-16
lines changed

tests/test_resource_tracker.py

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ def _resource_unlink(name, rtype):
2323
resource_tracker._CLEANUP_FUNCS[rtype](name)
2424

2525

26-
def get_rtracker_pid():
26+
def get_rtracker_fd():
2727
resource_tracker.ensure_running()
28-
return resource_tracker._resource_tracker._pid
28+
return resource_tracker._resource_tracker._fd
2929

3030

3131
class TestResourceTracker:
@@ -40,12 +40,12 @@ def test_resource_utils(self, rtype):
4040
assert not resource_exists(name, rtype)
4141

4242
def test_child_retrieves_resource_tracker(self):
43-
parent_rtracker_pid = get_rtracker_pid()
43+
parent_rtracker_fd = get_rtracker_fd()
4444
executor = ProcessPoolExecutor(max_workers=2)
45-
child_rtracker_pid = executor.submit(get_rtracker_pid).result()
45+
child_rtracker_fd = executor.submit(get_rtracker_fd).result()
4646

47-
# First simple pid retrieval check (see #200)
48-
assert child_rtracker_pid == parent_rtracker_pid
47+
# First simple fd retrieval check (see #200)
48+
assert child_rtracker_fd == parent_rtracker_fd
4949

5050
# Register a resource in the parent process, and un-register it in the
5151
# child process. If the two processes do not share the same
@@ -294,15 +294,12 @@ def test_loky_process_inherit_multiprocessing_resource_tracker(self):
294294
cmd = """if 1:
295295
from loky import get_reusable_executor
296296
from multiprocessing.shared_memory import SharedMemory
297-
from multiprocessing.resource_tracker import (
298-
_resource_tracker as mp_resource_tracker
299-
)
300297
301-
def mp_rtracker_getattrs():
298+
def mp_rtracker_getfd():
302299
from multiprocessing.resource_tracker import (
303300
_resource_tracker as mp_resource_tracker
304301
)
305-
return mp_resource_tracker._fd, mp_resource_tracker._pid
302+
return mp_resource_tracker._fd
306303
307304
308305
if __name__ == '__main__':
@@ -312,9 +309,9 @@ def mp_rtracker_getattrs():
312309
313310
# loky forces the creation of the resource tracker at process
314311
# creation so that loky processes can inherit its file descriptor.
315-
fd, pid = executor.submit(mp_rtracker_getattrs).result()
316-
assert fd == mp_resource_tracker._fd
317-
assert pid == mp_resource_tracker._pid
312+
parent_fd = mp_rtracker_getfd()
313+
child_fd = executor.submit(mp_rtracker_getfd).result()
314+
assert child_fd == parent_fd
318315
319316
# non-regression test for #242: unlinking in a loky process a
320317
# shared_memory segment tracked by multiprocessing and created its
@@ -326,5 +323,5 @@ def mp_rtracker_getattrs():
326323
p = subprocess.run(
327324
[sys.executable, "-c", cmd], capture_output=True, text=True
328325
)
329-
assert not p.stdout
330-
assert not p.stderr
326+
assert not p.stdout, p.stdout
327+
assert not p.stderr, p.stderr

0 commit comments

Comments
 (0)