Skip to content

Commit 2d7d3fd

Browse files
authored
Merge pull request #167 from jeremykenedy/analysis-0gJweE
Apply fixes from StyleCI
2 parents 5fec2a3 + cbe3f79 commit 2d7d3fd

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

src/Traits/HasRoleAndPermission.php

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -201,20 +201,18 @@ public function rolePermissions()
201201
}
202202

203203
if (config('roles.inheritance')) {
204-
return $permissionModel
205-
::select([$permissionTable . '.*', 'permission_role.created_at as pivot_created_at', 'permission_role.updated_at as pivot_updated_at'])
206-
->join('permission_role', 'permission_role.permission_id', '=', $permissionTable .'.id')
204+
return $permissionModel::select([$permissionTable.'.*', 'permission_role.created_at as pivot_created_at', 'permission_role.updated_at as pivot_updated_at'])
205+
->join('permission_role', 'permission_role.permission_id', '=', $permissionTable.'.id')
207206
->join($roleTable, $roleTable.'.id', '=', 'permission_role.role_id')
208207
->whereIn($roleTable.'.id', $this->getRoles()->pluck('id')->toArray())
209208
->orWhere($roleTable.'.level', '<', $this->level())
210-
->groupBy([$permissionTable . '.id', $permissionTable .'.name', $permissionTable .'.slug', $permissionTable .'.description', $permissionTable .'.model', $permissionTable .'.created_at', 'permissions.updated_at', $permissionTable .'.deleted_at', 'pivot_created_at', 'pivot_updated_at']);
209+
->groupBy([$permissionTable.'.id', $permissionTable.'.name', $permissionTable.'.slug', $permissionTable.'.description', $permissionTable.'.model', $permissionTable.'.created_at', 'permissions.updated_at', $permissionTable.'.deleted_at', 'pivot_created_at', 'pivot_updated_at']);
211210
} else {
212-
return $permissionModel
213-
::select([$permissionTable .'.*', 'permission_role.created_at as pivot_created_at', 'permission_role.updated_at as pivot_updated_at'])
214-
->join('permission_role', 'permission_role.permission_id', '=', $permissionTable .'.id')
211+
return $permissionModel::select([$permissionTable.'.*', 'permission_role.created_at as pivot_created_at', 'permission_role.updated_at as pivot_updated_at'])
212+
->join('permission_role', 'permission_role.permission_id', '=', $permissionTable.'.id')
215213
->join($roleTable, $roleTable.'.id', '=', 'permission_role.role_id')
216214
->whereIn($roleTable.'.id', $this->getRoles()->pluck('id')->toArray())
217-
->groupBy([$permissionTable . '.id', $permissionTable .'.name', $permissionTable .'.slug', $permissionTable .'.description', $permissionTable .'.model', $permissionTable .'.created_at', $permissionTable .'.updated_at', $permissionTable .'.deleted_at', 'pivot_created_at', 'pivot_updated_at']);
215+
->groupBy([$permissionTable.'.id', $permissionTable.'.name', $permissionTable.'.slug', $permissionTable.'.description', $permissionTable.'.model', $permissionTable.'.created_at', $permissionTable.'.updated_at', $permissionTable.'.deleted_at', 'pivot_created_at', 'pivot_updated_at']);
218216
}
219217
}
220218

src/config/roles.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
'permissionsTable' => env('ROLES_PERMISSIONS_DATABASE_TABLE', 'permissions'),
2020
'permissionsRoleTable' => env('ROLES_PERMISSION_ROLE_DATABASE_TABLE', 'permission_role'),
2121
'permissionsUserTable' => env('ROLES_PERMISSION_USER_DATABASE_TABLE', 'permission_user'),
22-
22+
2323
/*
2424
|--------------------------------------------------------------------------
2525
| GUI routes custom prefix

0 commit comments

Comments
 (0)