[2024-11-18 07:34:31.099087][] ERROR: Worker errored: Bunny\Channel::__construct(): Argument #1 ($connection) must be of type Bunny\Connection, null given, called in /opt/app/vendor/bunny/bunny/src/Client.php on line 154

[WyriHaximus]

[fronbasal]

Oh this is a bug? I thought the constructor arguments changed for v0.6.x and thus I pinned our composer ver to 0.5.5 😄

[WyriHaximus]

@fronbasal Caught this on one of my services at home using 0.6 and this came up. It is a bug for sure, but it was surprising to see. Just logged it here to fix before 0.6 will be out

[fronbasal]

Gotcha! Also saw this in dev and stage just a few days ago. Thank you for this amazing library and your engaged, skillful maintenance of this repository ♥️

[WyriHaximus]

Gotcha! Also saw this in dev and stage just a few days ago. Thank you for this amazing library and your engaged, skillful maintenance of this repository ♥️

If you have a stacktrace of it, please post it here or email it to me if you rather not have that public. It might help fix this.

[tomas-novotny]

This is happening (for example) when trying to connect in multiple asynchronous processes

use Bunny\Client;
use React\Promise\PromiseInterface;
use function React\Async\async;
use function React\Async\await;
use function React\Async\parallel;
use function React\Promise\resolve;

$client = new \Bunny\Client($options);

$promises = [];
for ($i = 0; $i < 5; $i++) {
    $promises[] = async(static function () use ($client): PromiseInterface {
        $client->channel();

        return resolve(null);
    });
}

await(parallel($promises));

$client->disconnect();

There is problem with checking if client is connected.

First process starts connecting and awaiting await($this->connector->connect($uri)).

Next process check that is already connected (isConnected is true with status ClientState::Connecting) and it ends up in line where it is using $this->connection - which is not set yet.

public function channel(): ChannelInterface
{
    if (!$this->isConnected()) {
        $this->connect();
    }

    $channelId = $this->findChannelId();

    $channel = new Channel($this->connection, $this, $channelId);
    //...
}

[WyriHaximus]

@tomas-novotny Sweet was thinking the same. I created a branch for this a while ago, let me know if #169 fixes it for you. Haven't looked at it in full isolation yet. My current set up where I use Bunny has some more levels on top of it

[tomas-novotny]

I have already created a #170 that solves this issue. Your changes from #169 just waiting indefinitely in this test.

[WyriHaximus]

Awesome, there's a reason I didn't put it up as PR earlier 😅. Will have a look after dinner and run an overnight test with it later tonight

[WyriHaximus]

Gotcha! Also saw this in dev and stage just a few days ago. Thank you for this amazing library and your engaged, skillful maintenance of this repository ♥️

@fronbasal Is 👆 still an issue with you with #170 merged into the 0.6 branch?

[fronbasal]

@fronbasal Is 👆 still an issue with you with #170 merged into the 0.6 branch?

I'll bump the package version to 0.6.x-dev and report back. We're only using bunny in our legacy PHP API (which we sunset end of last year), so I might not be able to trigger it again. If I do I'll get back to this issue with the stacktrace.

Thanks for the great work!