Skip to content

Ironfan broken under ruby > 2.0 #363

@andyleclair

Description

@andyleclair

A simple run of the specs will show (after swapping ruby-debug for byebug in the Gemfile) that Ironfan doesn't even run a little under ruby 2.1.2.

*[master][~/src/ironfan]$ bundle exec rake spec                                                                                                                                                                                                                                                                                                           
/Users/aleclair/.rvm/rubies/ruby-2.1.2/bin/ruby -S rspec spec/chef/cluster_bootstrap_spec.rb spec/chef/cluster_launch_spec.rb spec/gorillib/resolution_spec.rb spec/ironfan/cluster_spec.rb spec/ironfan/diff_spec.rb spec/ironfan/dsl_spec.rb spec/ironfan/ec2/cloud_provider_spec.rb spec/ironfan/ec2/elb_spec.rb spec/ironfan/ec2/security_group_spec.rb spec/ironfan/ec2_spec.rb spec/ironfan/manifest_spec.rb spec/ironfan/plugin_spec.rb spec/ironfan/realm_spec.rb spec/ironfan/security_group_spec.rb
/Users/aleclair/.rvm/gems/ruby-2.1.2/gems/gorillib-0.6.0/lib/gorillib/model/field.rb:141:in `initialize': Please supply an item type for field(:components,Gorillib::ModelCollection,{}) -- eg 'collection :components, of: FooClass' (RuntimeError)
    from /Users/aleclair/.rvm/gems/ruby-2.1.2/gems/gorillib-0.6.0/lib/gorillib/model/schema_magic.rb:24:in `new'
    from /Users/aleclair/.rvm/gems/ruby-2.1.2/gems/gorillib-0.6.0/lib/gorillib/model/schema_magic.rb:24:in `field'
    from /Users/aleclair/.rvm/gems/ruby-2.1.2/gems/gorillib-0.6.0/lib/gorillib/model/schema_magic.rb:33:in `collection'
    from /Users/aleclair/.rvm/gems/ruby-2.1.2/gems/gorillib-0.6.0/lib/gorillib/builder.rb:113:in `collection'
    from /Users/aleclair/src/ironfan/lib/ironfan/dsl/compute.rb:21:in `<class:Compute>'
    from /Users/aleclair/src/ironfan/lib/ironfan/dsl/compute.rb:16:in `<class:Dsl>'
    from /Users/aleclair/src/ironfan/lib/ironfan/dsl/compute.rb:4:in `<module:Ironfan>'
    from /Users/aleclair/src/ironfan/lib/ironfan/dsl/compute.rb:3:in `<top (required)>'
    from /Users/aleclair/src/ironfan/lib/ironfan/requirements.rb:23:in `require'
    from /Users/aleclair/src/ironfan/lib/ironfan/requirements.rb:23:in `<top (required)>'
    from /Users/aleclair/src/ironfan/lib/ironfan.rb:1:in `require'
    from /Users/aleclair/src/ironfan/lib/ironfan.rb:1:in `<top (required)>'
    from /Users/aleclair/src/ironfan/spec/spec_helper.rb:6:in `require'
    from /Users/aleclair/src/ironfan/spec/spec_helper.rb:6:in `<top (required)>'
    from /Users/aleclair/src/ironfan/spec/chef/cluster_bootstrap_spec.rb:1:in `require'
    from /Users/aleclair/src/ironfan/spec/chef/cluster_bootstrap_spec.rb:1:in `<top (required)>'
    from /Users/aleclair/.rvm/gems/ruby-2.1.2/gems/rspec-core-2.99.2/lib/rspec/core/configuration.rb:1065:in `load'
    from /Users/aleclair/.rvm/gems/ruby-2.1.2/gems/rspec-core-2.99.2/lib/rspec/core/configuration.rb:1065:in `block in load_spec_files'
    from /Users/aleclair/.rvm/gems/ruby-2.1.2/gems/rspec-core-2.99.2/lib/rspec/core/configuration.rb:1065:in `each'
    from /Users/aleclair/.rvm/gems/ruby-2.1.2/gems/rspec-core-2.99.2/lib/rspec/core/configuration.rb:1065:in `load_spec_files'
    from /Users/aleclair/.rvm/gems/ruby-2.1.2/gems/rspec-core-2.99.2/lib/rspec/core/command_line.rb:18:in `run'
    from /Users/aleclair/.rvm/gems/ruby-2.1.2/gems/rspec-core-2.99.2/lib/rspec/core/runner.rb:103:in `run'
    from /Users/aleclair/.rvm/gems/ruby-2.1.2/gems/rspec-core-2.99.2/lib/rspec/core/runner.rb:17:in `block in autorun'
/Users/aleclair/.rvm/rubies/ruby-2.1.2/bin/ruby -S rspec spec/chef/cluster_bootstrap_spec.rb spec/chef/cluster_launch_spec.rb spec/gorillib/resolution_spec.rb spec/ironfan/cluster_spec.rb spec/ironfan/diff_spec.rb spec/ironfan/dsl_spec.rb spec/ironfan/ec2/cloud_provider_spec.rb spec/ironfan/ec2/elb_spec.rb spec/ironfan/ec2/security_group_spec.rb spec/ironfan/ec2_spec.rb spec/ironfan/manifest_spec.rb spec/ironfan/plugin_spec.rb spec/ironfan/realm_spec.rb spec/ironfan/security_group_spec.rb failed

This behavior can be replicated in versions of ironfan going back to 4.5.0 (I didn't go any further back).

I tried to check out Gorillib to see what was going on there, however, I couldn't run the Gorillib specs under 2.1.2 either.

I also tried to run the specs under ruby 2.0.0-p481, p195, and p247 and none worked.

It seems that you have serious compatibility issues with ruby 2.x. You should at least mention that it won't run under ruby > 2.0 on the readme, or better yet, fix it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions