fix: OutOfSpace partition status returning to online (#4529)

Author: fraidev

crates/fluvio-controlplane-metadata/src/partition/status.rs

@@ -111,19 +111,18 @@ impl PartitionStatus {
     }
 
     pub fn is_online(&self) -> bool {
+        matches!(self.resolution, PartitionResolution::Online)
+    }
+
+    pub fn is_readable(&self) -> bool {
         matches!(
             self.resolution,
             PartitionResolution::Online | PartitionResolution::OutOfStorage
         )
     }
 
     pub fn is_offline(&self) -> bool {
-        matches!(
-            self.resolution,
-            PartitionResolution::Offline
-                | PartitionResolution::LeaderOffline
-                | PartitionResolution::ElectionLeaderFound
-        )
+        self.resolution == PartitionResolution::Offline
     }
 
     #[deprecated = "Replaced by lrs()"]

crates/fluvio-sc/src/controllers/partitions/reducer.rs

@@ -215,7 +215,7 @@ impl<C: MetadataItem> PartitionReducer<C> {
 
         for partition_kv_epoch in self.partition_store.read().await.values() {
             let partition_kv = partition_kv_epoch.inner();
-            if partition_kv.status.is_offline() {
+            if !partition_kv.status.is_readable() {
                 if partition_kv.spec.leader != online_leader_spu_id {
                     // switch leader if online leader is different
                     for replica_status in partition_kv.status.replica_iter() {