Skip to content

Commit 0d5c676

Browse files
committed
treewide: fix places where $(FPIC) is unquoted
Fixes part of issue #14921. When $(FPIC) gets added to TARGET_CFLAGS (for instance), we can count on $(TARGET_CFLAGS) in turn being quoted when it gets expanded. But there are a few places where $(FPIC) gets expanded directly into environment variables passed on the command line, such as when setting lt_cv_* variables as in this case. It's wrong to assume that the expansion of $(FPIC) won't require quoting (such as it containing spaces) if it has multiple compiler flags. Signed-off-by: Philip Prindeville <[email protected]>
1 parent 1e0eaa1 commit 0d5c676

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

libs/libredblack/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
99

1010
PKG_NAME:=libredblack
1111
PKG_VERSION:=1.3
12-
PKG_RELEASE:=3
12+
PKG_RELEASE:=4
1313

1414
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
1515
PKG_SOURCE_URL:=@SF/libredblack
@@ -38,7 +38,7 @@ define Package/libredblack/description
3838
endef
3939

4040
CONFIGURE_ARGS += --without-rbgen
41-
CONFIGURE_VARS += lt_cv_prog_cc_pic=$(FPIC)
41+
CONFIGURE_VARS += lt_cv_prog_cc_pic="$(FPIC)"
4242
MAKE_FLAGS += CFLAGS="$(TARGET_CFLAGS)"
4343

4444
define Build/InstallDev

sound/madplay/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
99

1010
PKG_NAME:=madplay
1111
PKG_VERSION:=0.15.2b
12-
PKG_RELEASE:=9
12+
PKG_RELEASE:=10
1313

1414
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
1515
PKG_SOURCE_URL:=@SF/mad \
@@ -51,7 +51,7 @@ CONFIGURE_ARGS += \
5151
--with-alsa
5252

5353
CONFIGURE_VARS += \
54-
lt_prog_compiler_pic=$(FPIC)
54+
lt_prog_compiler_pic="$(FPIC)"
5555

5656
MAKE_FLAGS += CFLAGS="$(TARGET_CFLAGS)"
5757

0 commit comments

Comments
 (0)