Fix BLE byte counter regression introduced in 9.0.0

In 8.0.0, addOnReceiveListener() called addOnReceiveCallback() which
registered callbacks in both _onReceiveListeners and the BLE-specific
_onCharateristicValueChangedListeners array. In 9.0.0 this was removed
to "avoid duplicate push", but Serial's addOnReceiveCallback() pushes
to _onReceiveListeners while BLE's pushes to its own separate array.

This meant the byte counter listener (added via addOnReceiveListener)
only went into _onReceiveListeners, but BLE's notification handler only
called _onCharateristicValueChangedListeners - so the counter never
incremented and MSP responses were never seen by the parser.

Fix: align BLE with Serial by using _onReceiveListeners throughout,
removing the now-unnecessary _onCharateristicValueChangedListeners array.
Includes debug logging to aid diagnosis if further issues arise.

Author: sensei-hacker

js/connection/connectionBle.js

@@ -48,7 +48,6 @@ class ConnectionBle extends Connection {
         this._writeCharacteristic   = false;
         this._device                = false;
         this._deviceDescription     = false;
-        this._onCharateristicValueChangedListeners = [];
         this._onDisconnectListeners   = [];
         this._reconnects = 0;
         this._handleOnCharateristicValueChanged = false;
@@ -166,12 +165,19 @@ class ConnectionBle extends Connection {
                         buffer[i] = event.target.value.getUint8(i);
                     }
 
-                    this._onCharateristicValueChangedListeners.forEach(listener => {
-                        listener({
-                            connectionId: 0xFF,
-                            data: buffer
-                        });
+                    const info = {
+                        connectionId: 0xFF,
+                        data: buffer
+                    };
+
+                    // TODO: Remove debug logging after BLE fix is verified in testing
+                    console.log(`[BLE FIX] ← Received ${buffer.byteLength} bytes, ${this._onReceiveListeners.length} listener(s), counter at ${this._bytesReceived}`);
+
+                    this._onReceiveListeners.forEach(listener => {
+                        listener(info);
                     });
+
+                    console.log(`[BLE FIX] Byte counter after dispatch: ${this._bytesReceived}`);
                 };
 
                 this._readCharacteristic.addEventListener('characteristicvaluechanged', this._handleOnCharateristicValueChanged)
@@ -242,11 +248,15 @@ class ConnectionBle extends Connection {
     }
 
     addOnReceiveCallback(callback){
-        this._onCharateristicValueChangedListeners.push(callback);
+        // TODO: Remove debug logging after BLE fix is verified in testing
+        console.log(`[BLE FIX] addOnReceiveCallback: listener count ${this._onReceiveListeners.length} → ${this._onReceiveListeners.length + 1}`);
+        this._onReceiveListeners.push(callback);
     }
 
     removeOnReceiveCallback(callback){
-        this._onCharateristicValueChangedListeners = this._onCharateristicValueChangedListeners.filter(listener => listener !== callback);
+        this._onReceiveListeners = this._onReceiveListeners.filter(listener => listener !== callback);
+        // TODO: Remove debug logging after BLE fix is verified in testing
+        console.log(`[BLE FIX] removeOnReceiveCallback: listener count now ${this._onReceiveListeners.length}`);
     }
 
     addOnReceiveErrorCallback(callback) {