Skip to content

Expand breakpoints Values to Match Chakra #38

@ianrohde

Description

@ianrohde

@jarstelfox found a bug that creates inconsistent Chakra breakpoint behavior. Basically, we are mixing breakpoint values - our primitive px values and Chakra's em values.

Let's fix that by expanding primitive breakpoints to match Chakras, so we can pass them all without explicitly defining:

// theme/foundations/breakpoints.ts

import { createBreakpoints } from '@chakra-ui/theme-tools';
import { breakpoint } from '@core-ds/primitives';

export default createBreakpoints(breakpoint);

TO-DO:

  • Add base value of 0px

2xl value was added in dd8e16d

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions