Merge branch 'main' of github.com:hyperledger/besu into test-errorprone-check

Author: macfarla

.github/workflows/verify_artifacts.py

@@ -6,26 +6,26 @@ def create_artifact_paths(version):
     artifacts_base_path = "https://hyperledger.jfrog.io/hyperledger/besu-maven/org/hyperledger/besu"
     # add to this list here to update the list of artifacts to check 
     artifacts = [
-        # besu/evm
-        f"{artifacts_base_path}/evm/{version}/evm-{version}.module",
-        f"{artifacts_base_path}/evm/{version}/evm-{version}.pom",
-        f"{artifacts_base_path}/evm/{version}/evm-{version}.jar",
-        # besu/plugin-api
-        f"{artifacts_base_path}/plugin-api/{version}/plugin-api-{version}.module",
-        f"{artifacts_base_path}/plugin-api/{version}/plugin-api-{version}.pom",
-        f"{artifacts_base_path}/plugin-api/{version}/plugin-api-{version}.jar",
-        # besu/metrics-core
-        f"{artifacts_base_path}/internal/metrics-core/{version}/metrics-core-{version}.module",
-        f"{artifacts_base_path}/internal/metrics-core/{version}/metrics-core-{version}.pom",
-        f"{artifacts_base_path}/internal/metrics-core/{version}/metrics-core-{version}.jar",
-        # besu/internal/core
-        f"{artifacts_base_path}/internal/core/{version}/core-{version}.module",
-        f"{artifacts_base_path}/internal/core/{version}/core-{version}.pom",
-        f"{artifacts_base_path}/internal/core/{version}/core-{version}.jar",
-        # besu/internal/config
-        f"{artifacts_base_path}/internal/config/{version}/config-{version}.module",
-        f"{artifacts_base_path}/internal/config/{version}/config-{version}.pom",
-        f"{artifacts_base_path}/internal/config/{version}/config-{version}.jar",
+        # besu-evm
+        f"{artifacts_base_path}/besu-evm/{version}/besu-evm-{version}.module",
+        f"{artifacts_base_path}/besu-evm/{version}/besu-evm-{version}.pom",
+        f"{artifacts_base_path}/besu-evm/{version}/besu-evm-{version}.jar",
+        # besu-plugin-api
+        f"{artifacts_base_path}/besu-plugin-api/{version}/besu-plugin-api-{version}.module",
+        f"{artifacts_base_path}/besu-plugin-api/{version}/besu-plugin-api-{version}.pom",
+        f"{artifacts_base_path}/besu-plugin-api/{version}/besu-plugin-api-{version}.jar",
+        # besu-metrics-core
+        f"{artifacts_base_path}/internal/besu-metrics-core/{version}/besu-metrics-core-{version}.module",
+        f"{artifacts_base_path}/internal/besu-metrics-core/{version}/besu-metrics-core-{version}.pom",
+        f"{artifacts_base_path}/internal/besu-metrics-core/{version}/besu-metrics-core-{version}.jar",
+        # internal/besu-ethereum-core
+        f"{artifacts_base_path}/internal/besu-ethereum-core/{version}/besu-ethereum-core-{version}.module",
+        f"{artifacts_base_path}/internal/besu-ethereum-core/{version}/besu-ethereum-core-{version}.pom",
+        f"{artifacts_base_path}/internal/besu-ethereum-core/{version}/besu-ethereum-core-{version}.jar",
+        # internal/besu-config
+        f"{artifacts_base_path}/internal/besu-config/{version}/besu-config-{version}.module",
+        f"{artifacts_base_path}/internal/besu-config/{version}/besu-config-{version}.pom",
+        f"{artifacts_base_path}/internal/besu-config/{version}/besu-config-{version}.jar",
         # bom
         f"{artifacts_base_path}/bom/{version}/bom-{version}.module",
         f"{artifacts_base_path}/bom/{version}/bom-{version}.pom",
@@ -38,7 +38,7 @@ def check_url(url):
     print(f"Checking artifact at: {url}")
     r = requests.head(url)
     if (r.status_code != 200):
-        raise Exception(f"Sorry, No artifact found at '{url}' !!!") 
+        raise Exception(f"Sorry, No artifact found at '{url}' !!!")
 
 def main():
     parser = argparse.ArgumentParser(description='Check besu artifacts')

CHANGELOG.md

@@ -1,36 +1,73 @@
 # Changelog
+
 ## Unreleased
+
+### Breaking Changes
+- Change in behavior for `eth_estimateGas`, to improve accuracy, when used on a network with a base fee market, the internal transaction simulation does not anymore underprice transactions, so if there are no gas pricing related fields specified in the request, then gas price for the transaction is set to the base fee value [#8888](https://github.com/hyperledger/besu/pull/8888)  
+
+### Upcoming Breaking Changes
+
+### Additions and Improvements
+- Improve transaction simulation and gas estimation when no gas pricing is present [#8888](https://github.com/hyperledger/besu/pull/8888)
+
+#### Fusaka devnets
+- EIP-7910 - `eth_config` JSON-RPC Method [#8417](https://github.com/hyperledger/besu/pull/8417)
+
+### Bug fixes
+
+
+## 25.7.0
 ### Breaking Changes
 - Changes in Maven coordinates of Besu artifacts to avoid possible collisions with other libraries when packaging plugins. See [Appendix A](#appendix-a) for a mapping. [#8589](https://github.com/hyperledger/besu/pull/8589) [#8746](https://github.com/hyperledger/besu/pull/8746)
 - `BesuContext` is removed, since deprecated in favor of `ServiceManager` since `24.12.0`
 - Remove the deprecated `--Xbonsai-trie-logs-pruning-window-size`, use `--bonsai-trie-logs-pruning-window-size` instead. [#8823](https://github.com/hyperledger/besu/pull/8823)
 - Remove the deprecated `--Xbonsai-limit-trie-logs-enabled`, use `--bonsai-limit-trie-logs-enabled` instead. [#8704](https://github.com/hyperledger/besu/issues/8704)
 - Remove the deprecated `--Xbonsai-trie-log-pruning-enabled`, use `--bonsai-limit-trie-logs-enabled` instead. [#8704](https://github.com/hyperledger/besu/issues/8704)
+- Remove the deprecated `--Xsnapsync-bft-enabled`. SNAP sync is now supported for BFT networks. [#8861](https://github.com/hyperledger/besu/pull/8861)
 - Remove methods from gas calculator deprecated since 24.4 `create2OperationGasCost`, `callOperationGasCost`, `createOperationGasCost`, and `cost` [#8817](https://github.com/hyperledger/besu/pull/8817)
 - Sunsetting features - for more context on the reasoning behind the deprecation of these features, including alternative options, read [this blog post](https://www.lfdecentralizedtrust.org/blog/sunsetting-tessera-and-simplifying-hyperledger-besu)
   - Stratum mining has been removed (part of PoW) [#8802](https://github.com/hyperledger/besu/pull/8802)
   - PoW RPCs removed: `eth_getWork`, `eth_submitWork`, `eth_getHashrate`, `eth_submitHashrate`, `eth_hashrate`
+- Introduce history expiry behaviour for mainnet [8875](https://github.com/hyperledger/besu/pull/8875)
+  - SNAP sync will now download only headers for pre-checkpoint (pre-merge) blocks
+  - `--snapsync-synchronizer-pre-checkpoint-headers-only-enabled` can be set to false to force SNAP sync to download pre-checkpoint (pre-merge) blocks
+  - `--history-expiry-prune` can be used to enable online pruning of pre-checkpoint (pre-merge) blocks as well as modifying database garbage collection parameters to free up disk space from the pruned blocks
 
 ### Upcoming Breaking Changes
 - `--Xbonsai-parallel-tx-processing-enabled` is deprecated, use `--bonsai-parallel-tx-processing-enabled` instead.
-- `--Xsnapsync-bft-enabled` is deprecated and will be removed in a future release. SNAP sync is supported for BFT networks.
+- `--Xsnapsync-server-enabled` is deprecated, use `--snapsync-server-enabled` instead [#8512](https://github.com/hyperledger/besu/pull/8512)
 - Sunsetting features - for more context on the reasoning behind the deprecation of these features, including alternative options, read [this blog post](https://www.lfdecentralizedtrust.org/blog/sunsetting-tessera-and-simplifying-hyperledger-besu)
   - Proof of Work consensus (PoW)
   - Fast Sync
 - Support for block creation on networks running a pre-Byzantium fork is deprecated for removal in a future release, after that to update Besu on nodes that build blocks, your network needs to be upgraded at least to the Byzantium fork. The main reason is to simplify world state management during block creation, since before Byzantium for each selected transaction, the receipt must contain the root hash of the modified world state, and this does not play well with the new plugin features and future work on parallelism.
+- `--Xsnapsync-synchronizer-pre-merge-headers-only-enabled` is deprecated and will be removed in a future release. Use `--snapsync-synchronizer-pre-checkpoint-headers-only-enabled` instead.
+- `--Xhistory-expiry-prune` is deprecated and will be removed in a future release. Use `--history-expiry-prune` instead.
 
 ### Additions and Improvements
 - Introduce the `TransactionValidatorService` to allow plugins to add custom validation rules [#8793](https://github.com/hyperledger/besu/pull/8793)
 - Implement rewardPercentile cap in eth_feeHistory [#8748](https://github.com/hyperledger/besu/pull/8748)
-- Enable parallel tx processing by default if Bonsai is used [#8668](https://github.com/hyperledger/besu/pull/8668)
-- Increase mainnet gas limit to 45M [#8824](https://github.com/hyperledger/besu/pull/8824)
 - Expose a method to get blob gas price from plugins [#8843](https://github.com/hyperledger/besu/pull/8843)
 - Experimental Bonsai Archive support [#7475](https://github.com/hyperledger/besu/pull/7475)
+- Use eth/69 by default [#8858](https://github.com/hyperledger/besu/pull/8858)
+- `--snapsync-server-enabled` New option to enable serving snap sync data [#8512](https://github.com/hyperledger/besu/pull/8512)
+- Introduce history expiry behaviour [#8875](https://github.com/hyperledger/besu/pull/8875)
+  - SNAP sync will now download only headers for pre-checkpoint (pre-merge) blocks
+  - `--snapsync-synchronizer-pre-checkpoint-headers-only-enabled` can be set to false to force SNAP sync to download pre-checkpoint (pre-merge) blocks
+  - `--history-expiry-prune` can be used to enable online pruning of pre-checkpoint (pre-merge) blocks as well as modifying database garbage collection parameters to free up disk space from the pruned blocks
+
+### Performance
+- Increase mainnet gas limit to 45M [#8824](https://github.com/hyperledger/besu/pull/8824)
+- Enable parallel tx processing by default if Bonsai is used [#8668](https://github.com/hyperledger/besu/pull/8668)
+- Remove redundant serialization of json params [#8847](https://github.com/hyperledger/besu/pull/8847)
+- Improve ExtCodeHash performance [#8811](https://github.com/hyperledger/besu/pull/8811)
+- Improve ModExp precompile performance [#8868](https://github.com/hyperledger/besu/pull/8868)
 
-#### Fusaka
+#### Fusaka (SFI'd and CFI'd)
 - EIP-7825 - Transaction gas limit cap [#8700](https://github.com/hyperledger/besu/pull/8700)
 - EIP-7823 - Modexp upper bounds [#8632](https://github.com/hyperledger/besu/pull/8632)
 - EIP-7892 - Max number of blobs per transaction [#8761](https://github.com/hyperledger/besu/pull/8761)
+- EIP-7934 - RLP Execution Block Size Limit [#8765](https://github.com/hyperledger/besu/pull/8765)
+- EIP-7951 - Precompile for secp256r1 Curve Support [#8750](https://github.com/hyperledger/besu/pull/8750)
 
 ### Bug fixes
 

acceptance-tests/dsl/src/main/java/org/hyperledger/besu/tests/acceptance/dsl/transaction/eth/EthEstimateGasTransaction.java

@@ -27,7 +27,7 @@
 public class EthEstimateGasTransaction implements Transaction<EthEstimateGas> {
   private final String contractAddress;
   private final String functionCall;
-  private final String from = "";
+  private final String from = "0xfe3b557e8fb62b89f4916b721be55ceb828dbd73";
 
   public EthEstimateGasTransaction(final String contractAddress, final String functionCall) {
     this.contractAddress = contractAddress;
@@ -45,7 +45,7 @@ public EthEstimateGas execute(final NodeRequests node) {
               new org.web3j.protocol.core.methods.request.Transaction(
                   from,
                   nonce,
-                  BigInteger.ZERO,
+                  null,
                   BigInteger.ZERO,
                   contractAddress,
                   BigInteger.ZERO,

acceptance-tests/tests/src/test/java/org/hyperledger/besu/tests/acceptance/bft/BftAcceptanceTestParameterization.java

@@ -66,25 +66,28 @@ public BftAcceptanceTestParameterization(
     this.createorWithValidatorFn = createorWithValidatorFn;
   }
 
-  public BesuNode createNode(BesuNodeFactory factory, String name) throws Exception {
+  public BesuNode createNode(final BesuNodeFactory factory, final String name) throws Exception {
     return creatorFn.create(factory, name, false, DataStorageFormat.FOREST);
   }
 
-  public BesuNode createBonsaiNodeFixedPort(BesuNodeFactory factory, String name) throws Exception {
+  public BesuNode createBonsaiNodeFixedPort(final BesuNodeFactory factory, final String name)
+      throws Exception {
     return creatorFn.create(factory, name, true, DataStorageFormat.BONSAI);
   }
 
-  public BesuNode createBonsaiArchiveNodeFixedPort(BesuNodeFactory factory, String name)
+  public BesuNode createBonsaiArchiveNodeFixedPort(final BesuNodeFactory factory, final String name)
       throws Exception {
     return creatorFn.create(factory, name, true, DataStorageFormat.X_BONSAI_ARCHIVE);
   }
 
-  public BesuNode createForestNodeFixedPort(BesuNodeFactory factory, String name) throws Exception {
+  public BesuNode createForestNodeFixedPort(final BesuNodeFactory factory, final String name)
+      throws Exception {
     return creatorFn.create(factory, name, true, DataStorageFormat.FOREST);
   }
 
   public BesuNode createNodeWithValidators(
-      BesuNodeFactory factory, String name, String[] validators) throws Exception {
+      final BesuNodeFactory factory, final String name, final String[] validators)
+      throws Exception {
     return createorWithValidatorFn.create(factory, name, validators);
   }
 }

acceptance-tests/tests/src/test/java/org/hyperledger/besu/tests/acceptance/clique/CliqueMiningAcceptanceTest.java

@@ -29,6 +29,7 @@
 import java.util.Map;
 import java.util.Optional;
 
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.web3j.protocol.core.DefaultBlockParameter;
 
@@ -82,6 +83,7 @@ public void shouldMineBlocksOnlyWhenTransactionsArePresentWhenCreateEmptyBlocksI
   }
 
   @Test
+  @Disabled("flaky see https://github.com/hyperledger/besu/issues/8862")
   public void shouldMineTransactionsOnMultipleNodes() throws IOException {
     final BesuNode minerNode1 = besu.createCliqueNode("miner1");
     final BesuNode minerNode2 = besu.createCliqueNode("miner2");
@@ -133,6 +135,7 @@ private void startClusterAndVerifyProducingBlocks(
   }
 
   @Test
+  @Disabled("flaky see https://github.com/hyperledger/besu/issues/8862")
   public void shouldStillMineWhenANodeFailsAndHasSufficientValidators() throws IOException {
     final BesuNode minerNode1 = besu.createCliqueNode("miner1");
     final BesuNode minerNode2 = besu.createCliqueNode("miner2");

app/src/main/java/org/hyperledger/besu/cli/BesuCommand.java

@@ -1318,6 +1318,11 @@ void configureNativeLibs(final Optional<NetworkName> configuredNetwork) {
         || genesisConfigOptionsSupplier.get().getCancunEOFTime().isPresent()
         || genesisConfigOptionsSupplier.get().getPragueTime().isPresent()
         || genesisConfigOptionsSupplier.get().getOsakaTime().isPresent()
+        || genesisConfigOptionsSupplier.get().getBpo1Time().isPresent()
+        || genesisConfigOptionsSupplier.get().getBpo2Time().isPresent()
+        || genesisConfigOptionsSupplier.get().getBpo3Time().isPresent()
+        || genesisConfigOptionsSupplier.get().getBpo4Time().isPresent()
+        || genesisConfigOptionsSupplier.get().getBpo5Time().isPresent()
         || genesisConfigOptionsSupplier.get().getFutureEipsTime().isPresent()) {
       if (kzgTrustedSetupFile != null) {
         KZGPointEvalPrecompiledContract.init(kzgTrustedSetupFile);

app/src/main/java/org/hyperledger/besu/cli/ConfigurationOverviewBuilder.java

@@ -417,7 +417,7 @@ public String build() {
     }
 
     if (isSnapServerEnabled) {
-      lines.add("Experimental Snap Sync server enabled");
+      lines.add("Snap Sync server enabled");
     }
 
     if (isHighSpec) {

app/src/main/java/org/hyperledger/besu/cli/config/NativeRequirement.java

@@ -15,6 +15,7 @@
 package org.hyperledger.besu.cli.config;
 
 import org.hyperledger.besu.crypto.SECP256K1;
+import org.hyperledger.besu.crypto.SECP256R1;
 import org.hyperledger.besu.evm.precompile.AltBN128PairingPrecompiledContract;
 import org.hyperledger.besu.evm.precompile.BLS12PairingPrecompiledContract;
 
@@ -48,6 +49,15 @@ record NativeRequirementResult(Boolean present, String libname, Optional<String>
                     ? Optional.empty()
                     : Optional.of("secp256k1: Native secp256k1 failed to load")));
 
+        var secp256r1 = new SECP256R1();
+        requirements.add(
+            new NativeRequirementResult(
+                secp256r1.maybeEnableNative(),
+                "secp256r1",
+                secp256r1.maybeEnableNative()
+                    ? Optional.empty()
+                    : Optional.of("secp256r1: Native secp256r1 failed to load")));
+
         requirements.add(
             new NativeRequirementResult(
                 AltBN128PairingPrecompiledContract.isNative(),

app/src/main/java/org/hyperledger/besu/cli/options/NativeLibraryOptions.java

@@ -53,7 +53,7 @@ public class NativeLibraryOptions {
           "Per default a native library is used for modexp. "
               + "If the Java implementation should be used instead, this option must be set to false",
       arity = "1")
-  private final Boolean nativeModExp = Boolean.TRUE;
+  private final Boolean nativeModExp = Boolean.FALSE;
 
   /** Default constructor. */
   NativeLibraryOptions() {}