mocking for http tests

Signed-off-by: Sally MacFarlane <[email protected]>

Author: macfarla

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceRpcApisTest.java

@@ -16,6 +16,7 @@
 
 import static java.util.Collections.singletonList;
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.lenient;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
@@ -33,6 +34,7 @@
 import org.hyperledger.besu.ethereum.api.jsonrpc.websocket.WebSocketConfiguration;
 import org.hyperledger.besu.ethereum.api.query.BlockchainQueries;
 import org.hyperledger.besu.ethereum.blockcreation.PoWMiningCoordinator;
+import org.hyperledger.besu.ethereum.chain.Blockchain;
 import org.hyperledger.besu.ethereum.chain.MutableBlockchain;
 import org.hyperledger.besu.ethereum.core.Block;
 import org.hyperledger.besu.ethereum.core.InMemoryKeyValueStorageProvider;
@@ -199,6 +201,7 @@ private JsonRpcHttpService createJsonRpcHttpServiceWithRpcApis(final String... r
 
   private JsonRpcHttpService createJsonRpcHttpServiceWithRpcApis(final JsonRpcConfiguration config)
       throws Exception {
+    setupMocksRequiredForBlockchainGenesisHash();
     final Set<Capability> supportedCapabilities = new HashSet<>();
     supportedCapabilities.add(EthProtocol.LATEST);
 
@@ -313,6 +316,8 @@ private JsonRpcHttpService createJsonRpcHttpService(
     jsonRpcConfiguration.setPort(0);
     webSocketConfiguration.setPort(0);
 
+    setupMocksRequiredForBlockchainGenesisHash();
+
     final Map<String, JsonRpcMethod> rpcMethods =
         new JsonRpcMethodsFactory()
             .methods(
@@ -433,6 +438,8 @@ public RequestBody createNetServicesRequestBody() {
 
   public JsonRpcHttpService getJsonRpcHttpService(final boolean[] enabledNetServices) {
 
+    setupMocksRequiredForBlockchainGenesisHash();
+
     JsonRpcConfiguration jsonRpcConfiguration = JsonRpcConfiguration.createDefault();
     WebSocketConfiguration webSocketConfiguration = WebSocketConfiguration.createDefault();
     P2PNetwork p2pNetwork = mock(P2PNetwork.class);
@@ -457,6 +464,14 @@ public JsonRpcHttpService getJsonRpcHttpService(final boolean[] enabledNetServic
         jsonRpcConfiguration, webSocketConfiguration, p2pNetwork, metricsConfiguration, natService);
   }
 
+  private void setupMocksRequiredForBlockchainGenesisHash() {
+    Blockchain blockchain = mock(Blockchain.class);
+    Block block = mock(Block.class);
+    lenient().when(blockchainQueries.getBlockchain()).thenReturn(blockchain);
+    lenient().when(blockchain.getGenesisBlock()).thenReturn(block);
+    lenient().when(block.getHash()).thenReturn(Hash.EMPTY);
+  }
+
   @Test
   public void netServicesTestWhenJsonrpcWebsocketP2pNetworkAndMatricesIsDisabled()
       throws Exception {

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceTest.java

@@ -65,7 +65,6 @@ public class JsonRpcHttpServiceTest extends JsonRpcHttpServiceTestBase {
 
   @BeforeAll
   public static void setup() throws Exception {
-    when(blockchainQueries.getBlockchain()).thenReturn(blockchain);
     initServerAndClient();
   }
 

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceTestBase.java

@@ -15,8 +15,10 @@
 package org.hyperledger.besu.ethereum.api.jsonrpc;
 
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
 
 import org.hyperledger.besu.config.StubGenesisConfigOptions;
+import org.hyperledger.besu.datatypes.Hash;
 import org.hyperledger.besu.ethereum.ProtocolContext;
 import org.hyperledger.besu.ethereum.api.ApiConfiguration;
 import org.hyperledger.besu.ethereum.api.graphql.GraphQLConfiguration;
@@ -30,6 +32,7 @@
 import org.hyperledger.besu.ethereum.chain.BadBlockManager;
 import org.hyperledger.besu.ethereum.chain.Blockchain;
 import org.hyperledger.besu.ethereum.chain.ChainHead;
+import org.hyperledger.besu.ethereum.core.Block;
 import org.hyperledger.besu.ethereum.core.MiningConfiguration;
 import org.hyperledger.besu.ethereum.core.Synchronizer;
 import org.hyperledger.besu.ethereum.eth.EthProtocol;
@@ -89,6 +92,7 @@ public class JsonRpcHttpServiceTestBase {
   protected static Blockchain blockchain;
   protected static BlockchainQueries blockchainQueries;
   protected static ChainHead chainHead;
+  protected static Block block;
   protected static Synchronizer synchronizer;
   protected static final Collection<String> JSON_RPC_APIS =
       Arrays.asList(
@@ -102,6 +106,10 @@ public static void initServerAndClient() throws Exception {
     ethPeersMock = mock(EthPeers.class);
     blockchain = mock(Blockchain.class);
     blockchainQueries = mock(BlockchainQueries.class);
+    when(blockchainQueries.getBlockchain()).thenReturn(blockchain);
+    block = mock(Block.class);
+    when(blockchain.getGenesisBlock()).thenReturn(block);
+    when(block.getHash()).thenReturn(Hash.EMPTY);
     chainHead = mock(ChainHead.class);
     synchronizer = mock(Synchronizer.class);