Skip to content

[TRACKING ISSUE] Disallow different types of generic records in GenericRecordBuilder.setGenericRecord API-1773 #923

Open
@hz-devops-test

Description

@hz-devops-test

The tracking issue for the Java side PR.

See hazelcast/hazelcast#23522 for details.


Right now, GenericRecordBuilder.setGenericRecord does not throw if the value is not of the same type of generic record. (compact for compact, portable for portable)

We instead throw a cast exception while trying to do toData. We should do it during the setter.

Breaking changes (list specific methods/types/messages):

  • If some users were misusing the API, they may be affected

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible
  • Send backports/forwardports if fix needs to be applied to past/future releases
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc

I don't think we need backports for this change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions