Skip to content

Commit ab67a56

Browse files
authored
Fix Java installation [1.4.z] (#1005)
The [tests are failing](https://github.com/hazelcast/hazelcast-go-client/actions/runs/10175906206/job/28144201884) because of a conflict between: - `JAVA_HOME` - Multiple Java installations on the runner Based on my [investigation and testing](hazelcast/client-compatibility-suites#127 (comment)) using `setup-java`, and avoiding hardcoding, resolves these issues.
1 parent 16cd443 commit ab67a56

File tree

5 files changed

+21
-26
lines changed

5 files changed

+21
-26
lines changed

.github/workflows/benchmark-all.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,11 @@ jobs:
1616
with:
1717
path: "$HOME/hazelcast-go-client"
1818

19-
- name: "Install Dependencies"
20-
run: |
21-
sudo apt-get update &&\
22-
sudo apt-get install -y openjdk-17-jdk-headless maven
19+
- name: "Setup JRE"
20+
uses: "actions/setup-java@v4"
21+
with:
22+
distribution: "zulu"
23+
java-version: "17"
2324

2425
- name: "Start Hazelcast Remote Controller"
2526
run: |

.github/workflows/test-all-32bits.yaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,12 @@ jobs:
1616
uses: "actions/checkout@v2"
1717
with:
1818
path: "$HOME/hazelcast-go-client"
19-
20-
- name: "Install Dependencies"
21-
run: |
22-
sudo apt-get update &&\
23-
sudo apt-get install -y openjdk-17-jdk-headless maven
19+
20+
- name: "Setup JRE"
21+
uses: "actions/setup-java@v4"
22+
with:
23+
distribution: "zulu"
24+
java-version: "17"
2425

2526
- name: "Start Hazelcast Remote Controller"
2627
run: |

.github/workflows/test-all.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,11 @@ jobs:
1717
with:
1818
path: "$HOME/hazelcast-go-client"
1919

20-
- name: "Install Dependencies"
21-
run: |
22-
sudo apt-get update &&\
23-
sudo apt-get install -y openjdk-17-jdk-headless maven
20+
- name: "Setup JRE"
21+
uses: "actions/setup-java@v4"
22+
with:
23+
distribution: "zulu"
24+
java-version: "17"
2425

2526
- name: "Start Hazelcast Remote Controller"
2627
run: |

.github/workflows/test-race.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,11 @@ jobs:
1616
with:
1717
path: "$HOME/hazelcast-go-client"
1818

19-
- name: "Install Dependencies"
20-
run: |
21-
sudo apt-get update &&\
22-
sudo apt-get install -y openjdk-17-jdk-headless maven
19+
- name: "Setup JRE"
20+
uses: "actions/setup-java@v4"
21+
with:
22+
distribution: "zulu"
23+
java-version: "17"
2324

2425
- name: "Start Hazelcast Remote Controller"
2526
run: |

rc.sh

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -183,15 +183,6 @@ echo "Java version:"
183183
java -version
184184
which java
185185
echo "JAVA_HOME: $JAVA_HOME"
186-
echo
187-
188-
echo "Use Java 17"
189-
export JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64
190-
export PATH=$JAVA_HOME/bin:$PATH
191-
java -version
192-
which java
193-
echo "JAVA_HOME: $JAVA_HOME"
194-
echo
195186

196187

197188
case "${1:-}" in

0 commit comments

Comments
 (0)