Skip to content

Commit 23a45ba

Browse files
mehmettokgozyuce
authored andcommitted
Various serialization fixes. (#932)
1 parent f7c6247 commit 23a45ba

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

aggregate/aggregate_distinct.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ func (a aggDistinct) ClassID() (classID int32) {
4646
func (a aggDistinct) WriteData(output serialization.DataOutput) {
4747
writeAttrPath(output, a.attrPath)
4848
// member side field, not used in client
49-
output.WriteInt64(0)
49+
output.WriteInt32(0)
5050
}
5151

5252
func (a *aggDistinct) ReadData(input serialization.DataInput) {
5353
a.attrPath = input.ReadString()
5454
// member side field, not used in client
55-
input.ReadInt64()
55+
input.ReadInt32()
5656
}
5757

5858
func (a aggDistinct) String() string {

internal/serialization/default_portable_writer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ func (pw *DefaultPortableWriter) GetRawDataOutput() serialization.DataOutput {
269269
pw.output.PWriteInt32(pw.offset+index*Int32SizeInBytes, pos)
270270
pw.raw = true
271271
}
272-
return pw.output.ObjectDataOutput
272+
return pw.output
273273
}
274274

275275
func (pw *DefaultPortableWriter) End() {

internal/serialization/object_data.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -659,6 +659,10 @@ func NewPositionalObjectDataOutput(length int, service *Service, bigEndian bool)
659659
return &PositionalObjectDataOutput{NewObjectDataOutput(length, service, bigEndian)}
660660
}
661661

662+
func (p *PositionalObjectDataOutput) WriteObject(object interface{}) {
663+
p.service.WriteObject(p, object)
664+
}
665+
662666
func (p *PositionalObjectDataOutput) PWriteByte(pos int32, v byte) {
663667
p.buffer[pos] = v
664668
}

internal/serialization/serialization.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ func (s *Service) ToData(object interface{}) (r Data, err error) {
6868
err = makeError(rec)
6969
}
7070
}()
71+
if object == nil {
72+
return nil, nil
73+
}
7174
if serData, ok := object.(Data); ok {
7275
return serData, nil
7376
}

0 commit comments

Comments
 (0)