Avoid PHP notice when searching for a project name that does not exist

Fixes kanboard#5383

Author: fguillot

app/Api/Procedure/ProjectProcedure.php

@@ -22,20 +22,35 @@ public function getProjectById($project_id)
     public function getProjectByName($name)
     {
         $project = $this->projectModel->getByName($name);
+
+        if (empty($project)) {
+            return false;
+        }
+
         ProjectAuthorization::getInstance($this->container)->check($this->getClassName(), 'getProjectByName', $project['id']);
         return $this->projectApiFormatter->withProject($project)->format();
     }
 
     public function getProjectByIdentifier($identifier)
     {
         $project = $this->projectModel->getByIdentifier($identifier);
+
+        if (empty($project)) {
+            return false;
+        }
+
         ProjectAuthorization::getInstance($this->container)->check($this->getClassName(), 'getProjectByIdentifier', $project['id']);
         return $this->projectApiFormatter->withProject($project)->format();
     }
 
     public function getProjectByEmail($email)
     {
         $project = $this->projectModel->getByEmail($email);
+
+        if (empty($project)) {
+            return false;
+        }
+
         ProjectAuthorization::getInstance($this->container)->check($this->getClassName(), 'getProjectByEmail', $project['id']);
         return $this->projectApiFormatter->withProject($project)->format();
     }

tests/integration/ProjectProcedureTest.php

@@ -11,6 +11,7 @@ public function testAll()
         $this->assertCreateTeamProject();
         $this->assertGetProjectById();
         $this->assertGetProjectByName();
+        $this->assertGetInexistingProjectByName();
         $this->assertGetAllProjects();
         $this->assertUpdateProject();
         $this->assertUpdateProjectIdentifier();
@@ -42,6 +43,12 @@ public function assertGetProjectByName()
         $this->assertEquals('Description', $project['description']);
     }
 
+    public function assertGetInexistingProjectByName()
+    {
+        $project = $this->app->getProjectByName('inexisting project');
+        $this->assertFalse($project);
+    }
+
     public function assertGetAllProjects()
     {
         $projects = $this->app->getAllProjects();