Skip to content

Run tests in separate process so that we actually test loading proto definitions at runtime #3552

@mstoykov

Description

@mstoykov

Originally raised in this comment by @thiagodpf.

What?

The current unit tests run the server and clients in the same process.

gRPC seems to have a global registry for types, so once the server loads them, the client doesn't need to.

This means that all tests that test that clients actually manage to load types correctly only with .proto files are not actually testing that :(

Solutions:

Preferably go test ./... should run the unit tests with the server and client as separate process - preferably even separate from the main go test one 🤔

This sounds involved.

A quicker solution will be to have another CI step that runs a server + k6 run script.js exercising the most common cases.

Both will be best.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions