Add tests for non-string key types #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://datatracker-ietf-org.lucaspardue.com/doc/draft-rundgren-cbor-core/ allows for key types besides string. This adds tests proving that non-string key types are supported. DAG-CBOR restricts map keys to string type. However, serde_ipld_dagcbor, the crate from which this crate was forked did not restrict key types in practice. We add some tests to prove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datatracker-ietf-org.lucaspardue.com/doc/draft-rundgren-cbor-core/ allows for key types besides string.
This adds tests proving that non-string key types are supported.
DAG-CBOR restricts map keys to string type. However, serde_ipld_dagcbor, the crate from which this crate was forked did not restrict key types in practice. We add some tests to prove it.