Skip to content

Website: Favicon not working #47

Open
@Adeesh-devanand

Description

@Adeesh-devanand
Contributor

Can anyone who has previously used jekyll, mmistakes theme please help fix the website favicon.

Here's the link to the config.yml file

Thank you for your help!!

Activity

gopaddle-io

gopaddle-io commented on Feb 28, 2022

@gopaddle-io
Owner

Please send pull requests to SODACODE-2022

aimanfatima

aimanfatima commented on Mar 13, 2022

@aimanfatima

Can I fix this? I believe only favicon.ico is missing in the assets/images folder.
<link rel="shortcut icon" type="image/x-icon" href="{{ site.baseurl }}/assets/images/favicon.ico"> https://github.com/gopaddle-io/configurator/blob/329f3c0ee731422be206a2a936de875226f6e67a/docs/_includes/head-custom.html
I've generated a favicon using https://realfavicongenerator.ne which I can place in the above folder, and it should work I guess?
The favicon generated looks like this -
image

gopaddle-io

gopaddle-io commented on Mar 14, 2022

@gopaddle-io
Owner

Yes, you are right. We need a favicon as per the sample you had shared.

Adeesh-devanand

Adeesh-devanand commented on Mar 16, 2022

@Adeesh-devanand
ContributorAuthor

Hey @aimanfatima, sure go ahead and send a pull request. I will test it on my environment before merging the code.

aimanfatima

aimanfatima commented on Mar 16, 2022

@aimanfatima

@Adeesh-devanand created a PR
#91
please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @aimanfatima@gopaddle-io@Adeesh-devanand

      Issue actions

        Website: Favicon not working · Issue #47 · gopaddle-io/configurator