Merge pull request #909 from google/subst

ci: Run golangci-lint on pull requests and update version.

Author: jaqx0r

.github/workflows/golangci-lint.yml

@@ -7,21 +7,27 @@ on:
       - main
   pull_request:
 
-permissions:
-  # golangci-lint does annotations, not comments
-  # No-one knows what an annotation is, but I suspect it's printing file:line: msg to stdout.
-  # https://github.community/t/what-are-annotations/16173/2
-  checks: none
-
 jobs:
   golangci:
     name: lint
     runs-on: ubuntu-latest
+    permissions:
+      # contents required to read the change
+      contents: read
+      # allow read access to any pull request
+      pull-requests: read
+      # golangci-lint does annotations, not comments, which needs `checks` to annotate the code.
+      # These are hidden in the code, and not visible as comments in the PR.
+      # https://github.com/golangci/golangci-lint-action/issues/5
+      # No-one knows what an annotation is, but I suspect it's printing file:line: msg to stdout.
+      # https://github.community/t/what-are-annotations/16173/2
+      checks: write
     steps:
       - uses: actions/checkout@v4
       - uses: golangci/golangci-lint-action@v6
         with:
           # Required: the version of golangci-lint is required and must be
           # specified without patch version: we always use the latest patch
           # version.
-          version: v1.57
+          version: v1.59
+          only-new-issues: ${{ github.event_name == 'pull_request' }}

.golangci.yml

@@ -37,7 +37,6 @@ linters:
     - depguard
     - errcheck # handled by gosec, lots of false posi
     - exhaustive # this false-positives for switches with a default
-    - exhaustivestruct # too noisy, labelling fields is not my jam
     - exhaustruct # above, renamed
     - forbidigo # exclude non prod tools
     - forcetypeassert # too many at the moment
@@ -48,13 +47,9 @@ linters:
     - gocognit # boo cyclomatic complexity
     - gocyclo  # boo cyclomatic complexity
     - godox # TODOs are fine
-    - golint # deprecated
     - gomnd    # magic numbers in test tables are fine actually
     - gosec # run independently
-    - ifshort    # buggy, false positives
-    - interfacer # deprecated
     - lll # go says long lines are ok, and this is trivially automatable
-    - maligned # deprecated
     - musttag # don't agree with the premise
     - nakedret    # weird thing to report on
     - nestif # cognitive complexity