Skip to content

Commit f68fba9

Browse files
authored
cleanup editor export (#4086)
1 parent 8d63780 commit f68fba9

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

packages/space-opera/src/components/best_practices/constants.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,9 @@ const onProgress = (event) => {
4444
updatingBar.style.width = \`\${event.detail.totalProgress * 100}%\`;
4545
if (event.detail.totalProgress === 1) {
4646
progressBar.classList.add('hide');
47+
event.target.removeEventListener('progress', onProgress);
4748
} else {
4849
progressBar.classList.remove('hide');
49-
if (event.detail.totalProgress === 0) {
50-
event.target.querySelector('.center-pre-prompt').classList.add('hide');
51-
}
5250
}
5351
};
5452
document.querySelector('model-viewer').addEventListener('progress', onProgress);`;

packages/space-opera/src/components/best_practices/render_best_practices.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
*/
1717

1818
import {html} from 'lit';
19+
1920
import {getMobileModelViewer} from '../mobile_view/reducer';
2021
import {getModelViewer} from '../model_viewer_preview/reducer';
2122

@@ -42,9 +43,6 @@ export const onProgress = (event) => {
4243
event.target.removeEventListener('progress', onProgress);
4344
} else {
4445
progressBar.classList.remove('hide');
45-
if (event.detail.totalProgress === 0) {
46-
event.target.querySelector('.center-pre-prompt')?.classList.add('hide');
47-
}
4846
}
4947
};
5048

packages/space-opera/src/components/best_practices/styles.css.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,15 @@ export const modelViewerStyles: CSSResult = css`:not(:defined) > * {
2121
display: none;
2222
}
2323
24+
html {
25+
height: 100%;
26+
}
27+
2428
body {
2529
margin: 0;
2630
padding: 0;
27-
width: 100vw;
28-
height: 100vh;
31+
width: 100%;
32+
height: 100%;
2933
}
3034
3135
model-viewer {

0 commit comments

Comments
 (0)