Skip to content

Commit e88f462

Browse files
authored
fix deployment (#4406)
1 parent 6e3af76 commit e88f462

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

.github/workflows/deploy-documentation.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,14 @@ jobs:
2222
# - name: Lint TypeScript sources
2323
# run: npm run lint
2424

25-
- name: Bootstrap packages
26-
run: npm run bootstrap
27-
2825
- name: Build packages
2926
run: npm run build
3027

3128
- name: Generate fidelity artifacts
3229
continue-on-error: true
3330
uses: GabrielBB/[email protected]
3431
with:
35-
run: ./node_modules/.bin/lerna run --scope @google/model-viewer-render-fidelity-tools test --stream
32+
run: npm run test --workspace=@google/model-viewer-render-fidelity-tools
3633

3734
- name: Stage documentation artifacts
3835
run: ./packages/modelviewer.dev/scripts/ci-before-deploy.sh

README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ Then, perform the following steps to get set up for development:
3131
git clone --depth=1 [email protected]:google/model-viewer.git
3232
cd model-viewer
3333
npm install
34-
npm run bootstrap
3534
```
3635

3736
Note: depth=1 keeps you from downloading our ~3Gb of history, which is dominated by all the versions of our golden render fidelity images.
@@ -40,7 +39,7 @@ The following global commands are available:
4039

4140
Command | Description
4241
------------------------------ | -----------
43-
`npm run bootstrap` | Bootstraps the project for development and cross-links sub-projects
42+
`npm ci` | Install dependencies and cross-links sub-projects
4443
`npm run build` | Runs the build step for all sub-projects
4544
`npm run serve` | Runs a web server and opens a new browser tab pointed to the local copy of modelviewer.dev (don't forget to build!)
4645
`npm run test` | Runs tests in all sub-projects that have them
@@ -61,7 +60,6 @@ To clone via HTTPS in WSL (there are known file permissions issues with SSH keys
6160
git clone --depth=1 https://github.com/google/model-viewer.git
6261
cd model-viewer
6362
npm install
64-
npm run bootstrap
6563
```
6664

6765
To run tests in WSL, you need to bind `CHROME_BIN`:

0 commit comments

Comments
 (0)