Skip to content

Commit cbdb507

Browse files
authored
Prevents error on 'progress' event with default progress bar. (#2084)
Automatically remove event listener on load complete.
1 parent d47c250 commit cbdb507

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

packages/space-opera/src/components/best_practices/render_best_practices.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,12 @@ export function renderProgressBar(isEditor) {
3434
export const onProgress = (event) => {
3535
const progressBar = event.target.querySelector('.progress-bar');
3636
const updatingBar = event.target.querySelector('.update-bar');
37+
if (!progressBar || !updatingBar)
38+
return;
3739
updatingBar.style.width = `${event.detail.totalProgress * 100}%`;
3840
if (event.detail.totalProgress === 1) {
3941
progressBar.classList.add('hide');
42+
event.target.removeEventListener('progress', onProgress);
4043
} else {
4144
progressBar.classList.remove('hide');
4245
if (event.detail.totalProgress === 0) {

0 commit comments

Comments
 (0)