keep roughnessMipmapper from breaking USDZExporter (#2878)

elalish · web-flow · commit 38bf54b071ec · 2021-10-15T10:48:14.000-07:00
diff --git a/packages/model-viewer/src/three-components/gltf-instance/ModelViewerGLTFInstance.ts b/packages/model-viewer/src/three-components/gltf-instance/ModelViewerGLTFInstance.ts
@@ -157,7 +157,9 @@ export class ModelViewerGLTFInstance extends GLTFInstance {
       // clobber the camera.
       const {enabled} = threeRenderer.xr;
       threeRenderer.xr.enabled = false;
+      const {image} = clone.roughnessMap;
       roughnessMipmapper.generateMipmaps(clone as MeshStandardMaterial);
+      clone.roughnessMap.image = image;
       threeRenderer.xr.enabled = enabled;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,9 @@ export class ModelViewerGLTFInstance extends GLTFInstance {`
`157`	`157`	`// clobber the camera.`
`158`	`158`	`const {enabled} = threeRenderer.xr;`
`159`	`159`	`threeRenderer.xr.enabled = false;`
	`160`	`+ const {image} = clone.roughnessMap;`
`160`	`161`	`roughnessMipmapper.generateMipmaps(clone as MeshStandardMaterial);`
	`162`	`+ clone.roughnessMap.image = image;`
`161`	`163`	`threeRenderer.xr.enabled = enabled;`
`162`	`164`	`}`
`163`	`165`