Skip to content

Commit 0084be0

Browse files
small refactor to reduce duplication code (#5050)
Follow up to the previous direct commits to the master branch.
1 parent 37935aa commit 0084be0

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

packages/model-viewer/src/three-components/ARRenderer.ts

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -326,23 +326,22 @@ export class ARRenderer extends EventDispatcher<
326326
}
327327
}
328328

329+
private setupController(controller: XRController) {
330+
this.setupXRControllerLine(controller);
331+
controller.addEventListener('selectstart', this.onControllerSelectStart);
332+
controller.addEventListener('selectend', this.onControllerSelectEnd);
333+
}
329334
private setupXRControllers() {
330335
this.xrController1 = this.threeRenderer.xr.getController(0) as XRController;
331336
this.xrController2 = this.threeRenderer.xr.getController(1) as XRController;
332-
333-
this.setupXRControllerLine(this.xrController1);
334-
this.setupXRControllerLine(this.xrController2);
335-
336-
this.xrController1.addEventListener('selectstart', this.onControllerSelectStart);
337-
this.xrController1.addEventListener('selectend', this.onControllerSelectEnd);
338-
339-
this.xrController2.addEventListener('selectstart', this.onControllerSelectStart);
340-
this.xrController2.addEventListener('selectend', this.onControllerSelectEnd);
341-
337+
338+
this.setupController(this.xrController1);
339+
this.setupController(this.xrController2);
340+
342341
this.scaleLine.name = 'scale line';
343342
this.scaleLine.visible = false;
344343
this.xrController1.add(this.scaleLine);
345-
344+
346345
// Add controllers to the scene
347346
const scene = this.presentedScene!;
348347
scene.add(this.xrController1);

0 commit comments

Comments
 (0)