Skip to content

Restore missing make generate and make check-generate targets #1107

@seshachalam-yv

Description

@seshachalam-yv
Contributor

How to categorize this issue?

/area dev-productivity
/kind bug

What happened:

The make generate and make check-generate targets are missing from the project root Makefile

What you expected to happen:

I expected the make generate and make check-generate commands to be available in the etcd-druid project, allowing me to generate mocks.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

This issue seems to have arisen after pull request #777 was merged. The goal is to bring back the make generate and make check-generate commands to restore the ability to generate mocks.

Environment:

  • Gardener version (if relevant):
  • etcd-druid version:
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • Others:

Activity

seshachalam-yv

seshachalam-yv commented on May 30, 2025

@seshachalam-yv
ContributorAuthor

/assign @Shreyas-s14

added this to the v0.31.0 milestone on May 30, 2025
unmarshall

unmarshall commented on May 30, 2025

@unmarshall
Contributor

These targets have been moved to the API go module. Can you please explain why are they required in the project root?

unmarshall

unmarshall commented on May 30, 2025

@unmarshall
Contributor

Ok, i had a discussion with @seshachalam-yv and till we are using mocks (internal/mock) for client and manager we should have a target at the project root as well so that these are regenerated when k8s/controller-runtime version changes.

Also when you introduce the target at the project root, please also call the make generate and make check-generate targets that are defined in API go module. This will ease the usage as only one make target can then be invoked.

NOTE: Please retain the make generate/check-generate targets that are defined in API go module. What should be introduced additionally is an ability to just call go generate ./....

As @seshachalam-yv pointed out that you will also need to change the prow job configuration in ci-infra github project.
Can you please add these as sub-tasks and only close this when all of these are done as well?

unpinned this issue on May 30, 2025
modified the milestones: v0.31.0, v0.32.0 on Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area/dev-productivityDeveloper productivity related (how to improve development)kind/bugBug

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @unmarshall@ishan16696@gardener-robot@Shreyas-s14@seshachalam-yv

      Issue actions

        Restore missing `make generate` and `make check-generate` targets · Issue #1107 · gardener/etcd-druid