-
Notifications
You must be signed in to change notification settings - Fork 53
Open
Labels
area/dev-productivityDeveloper productivity related (how to improve development)Developer productivity related (how to improve development)kind/bugBugBug
Milestone
Description
How to categorize this issue?
/area dev-productivity
/kind bug
What happened:
The make generate
and make check-generate
targets are missing from the project root Makefile
What you expected to happen:
I expected the make generate
and make check-generate
commands to be available in the etcd-druid
project, allowing me to generate mocks.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
This issue seems to have arisen after pull request #777 was merged. The goal is to bring back the make generate
and make check-generate
commands to restore the ability to generate mocks.
Environment:
- Gardener version (if relevant):
- etcd-druid version:
- Kubernetes version (use
kubectl version
): - Cloud provider or hardware configuration:
- Others:
Metadata
Metadata
Assignees
Labels
area/dev-productivityDeveloper productivity related (how to improve development)Developer productivity related (how to improve development)kind/bugBugBug
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
seshachalam-yv commentedon May 30, 2025
/assign @Shreyas-s14
unmarshall commentedon May 30, 2025
These targets have been moved to the API go module. Can you please explain why are they required in the project root?
unmarshall commentedon May 30, 2025
Ok, i had a discussion with @seshachalam-yv and till we are using mocks (internal/mock) for client and manager we should have a target at the project root as well so that these are regenerated when k8s/controller-runtime version changes.
Also when you introduce the target at the project root, please also call the make generate and make check-generate targets that are defined in API go module. This will ease the usage as only one make target can then be invoked.
As @seshachalam-yv pointed out that you will also need to change the prow job configuration in
ci-infra
github project.Can you please add these as sub-tasks and only close this when all of these are done as well?