Skip to content

More robust handling of unexpected payloads #36

@sliemeobn

Description

@sliemeobn
Contributor

Currently unexpected payloads sent by the broker will result in either a crash (precondition) or undefined behavior, because it is basically ignored.

All preconditions that can actually occur should rather cause an error and take the channel down cleanly (eg: a valid frame from the broker that is unexpected).

On the other hand, valid broker response frames that arrive without a matching requests are ignored - or worse, just forwarded up the chain to a mismatching request - only to be then converted to an error (outside of the channel handling pipeline).

Ideally, the channel pipeline understands these mismatches and also cleanly takes the channel down with an error.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @sliemeobn

        Issue actions

          More robust handling of unexpected payloads · Issue #36 · funcmike/rabbitmq-nio