Skip to content

Commit 55c4409

Browse files
authored
Paket.dependencies: Allow Paket.Core to be in pre-release version to get the integration-tests pass. (#2791)
* Paket.dependencies: We have to allow Paket.Core to be in pre-release version to get the integration-tests pass. * unit-test was assuming line-numbers which increased by one due to previous commit
1 parent accd2f4 commit 55c4409

File tree

11 files changed

+24
-14
lines changed

11 files changed

+24
-14
lines changed

integrationtests/core-no-dependencies-hello-world/before/paket.dependencies

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@ source https://api.nuget.org/v3/index.json
66
source https://ci.appveyor.com/nuget/fake
77

88
nuget Fake.Runtime prerelease
9-
nuget FSharp.Core prerelease
9+
nuget FSharp.Core prerelease
10+
nuget Paket.Core prerelease

integrationtests/core-reference-assemblies-net60101-rollforward/before/reference-assemblies.fsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ storage: none
33
source https://api.nuget.org/v3/index.json
44
source ../../../release/dotnetcore
55
nuget Fake.Runtime prerelease
6-
nuget FSharp.Core prerelease"
6+
nuget FSharp.Core prerelease
7+
nuget Paket.Core prerelease"
78

89
open Fake.Runtime
910

integrationtests/core-reference-assemblies-net60101/before/reference-assemblies.fsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ storage: none
33
source https://api.nuget.org/v3/index.json
44
source ../../../release/dotnetcore
55
nuget Fake.Runtime prerelease
6-
nuget FSharp.Core prerelease"
6+
nuget FSharp.Core prerelease
7+
nuget Paket.Core prerelease"
78

89
open Fake.Runtime
910

integrationtests/core-reference-fake-core-targets/before/reference_fake-targets.fsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ source ../../../release/dotnetcore
55
66
nuget Fake.Core.Target prerelease
77
nuget System.Reactive.Compatibility
8-
nuget FSharp.Core prerelease"
8+
nuget FSharp.Core prerelease
9+
nuget Paket.Core prerelease"
910
#endif
1011

1112
printfn "before load"

integrationtests/core-reference-fake-runtime/before/reference_fake-runtime.fsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ source ../../../release/dotnetcore
66
//source https://ci.appveyor.com/nuget/paket
77
88
nuget Fake.Runtime prerelease
9-
nuget FSharp.Core prerelease"
9+
nuget FSharp.Core prerelease
10+
nuget Paket.Core prerelease"
1011
#endif
1112
#load ".fake/reference_fake-runtime.fsx/intellisense.fsx"
1213

integrationtests/core-simple-failed-to-compile/before/fail-to-compile.fsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ source ../../../release/dotnetcore
55
//source https://ci.appveyor.com/nuget/paket
66
77
nuget Fake.Runtime prerelease
8-
nuget FSharp.Core prerelease"
8+
nuget FSharp.Core prerelease
9+
nuget Paket.Core prerelease"
910
#endif
1011
open klajsdhgfasjkhd
1112

integrationtests/core-simple-runtime-error/before/runtime-error.fsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
#r "paket: //source https://ci.appveyor.com/nuget/paket"
66
#r "paket: nuget Fake.Runtime prerelease"
77
#r "paket: nuget FSharp.Core prerelease"
8+
#r "paket: nuget Paket.Core prerelease"
89
#endif
910

1011
// Issue https://github.com/fsharp/FAKE/issues/2121

integrationtests/core-use-external-paket-dependencies/before/paket.dependencies

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@ source ../../../release/dotnetcore
55

66
nuget Fake.Runtime prerelease
77
nuget FSharp.Core prerelease
8-
nuget Microsoft.NETCore.App
8+
nuget Microsoft.NETCore.App
9+
nuget Paket.Core prerelease

paket.dependencies

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ group fakemodule
5555
nuget FParsec
5656
nuget Octokit
5757
nuget Newtonsoft.Json
58-
nuget Paket.Core 8.1.0-alpha004
58+
nuget Paket.Core prerelease
5959
nuget NuGet.Protocol
6060
nuget NuGet.Packaging
6161
nuget Mono.Cecil prerelease

src/test/Fake.Core.IntegrationTests/SimpleHelloWorldTests.fs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ let tests =
249249
"Expected correct declaration of 'Start'"
250250
{ Declaration.Empty with
251251
File = scriptFile
252-
Line = 36 }
252+
Line = 37 }
253253
startTarget.Declaration
254254

255255
Expect.equal "Expected correct hard dependencies of 'Start'" [] startTarget.HardDependencies
@@ -261,7 +261,7 @@ let tests =
261261
"Expected correct declaration of 'TestTarget'"
262262
{ Declaration.Empty with
263263
File = scriptFile
264-
Line = 38 }
264+
Line = 39 }
265265
testTarget.Declaration
266266

267267
Expect.equal
@@ -270,7 +270,7 @@ let tests =
270270
Declaration =
271271
{ Declaration.Empty with
272272
File = scriptFile
273-
Line = 45 } } ]
273+
Line = 46 } } ]
274274
testTarget.HardDependencies
275275

276276
Expect.equal "Expected correct description of 'TestTarget'" "" testTarget.Description

src/test/Fake.Core.UnitTests/Fake.DotNet.MSBuild.fs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,18 @@ open Expecto
66

77
[<Tests>]
88
let tests =
9-
let flagsTestCase name changeBuildArgs expected =
9+
let flagsTestCase name changeBuildArgs (expected: string) =
1010
testCase name
1111
<| fun _ ->
1212
let _, cmdLine = MSBuild.buildArgs changeBuildArgs
1313

1414
let expected =
15+
let trimmed = expected.Trim()
16+
1517
if BuildServer.ansiColorSupport then
16-
$"%s{expected} /clp:ForceConsoleColor".Trim()
18+
$"%s{trimmed} /clp:ForceConsoleColor".Trim()
1719
else
18-
expected.Trim()
20+
trimmed
1921

2022
let expected = $"/m /nodeReuse:False {expected} /p:RestorePackages=False".Trim()
2123

0 commit comments

Comments
 (0)