chore(W-16301365): update node to v20 + bunch of deps (#606)

CristiCanizales · web-flow · commit 598215683f84 · 2025-03-10T21:20:57.000-03:00
* chore: node update

* chore: update nvmrc file

* chore: some more dependencies bumps

* chore: some more dependencies bumps part 2

* chore: some more dependencies bumps part 3

* chore: some more dependencies bumps part 4 - glob, jest, shell

* chore: undo glob bump. ugh windows
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v18.11.0
+v20.17.0
diff --git a/package.json b/package.json
@@ -7,15 +7,15 @@
     "url": "https://github.com/forcedotcom/lightning-language-server.git"
   },
   "engines": {
-    "node": ">=18.11.0"
+    "node": ">=20.17.0"
   },
   "devDependencies": {
     "@commitlint/cli": "^7",
     "@commitlint/config-conventional": "^7",
     "commitizen": "^3.0.5",
     "cz-conventional-changelog": "^2.1.0",
-    "@types/jest": "^27.4.0",
-    "@types/node": "^18.11.0",
+    "@types/jest": "^29.5.14",
+    "@types/node": "^20.0.0",
     "@typescript-eslint/eslint-plugin": "^2.22.0",
     "@typescript-eslint/parser": "^2.22.0",
     "eslint": "^6.8.0",
@@ -29,7 +29,7 @@
     "prettier": "1.19.1",
     "patch-package": "^6.0.5",
     "rimraf": "^3.0.1",
-    "shelljs": "^0.8.3",
+    "shelljs": "^0.8.5",
     "typescript": "^5.0.4"
   },
   "scripts": {
@@ -73,6 +73,7 @@
   "resolutions": {
     "set-value": "^2.0.1",
     "js-yaml": "^3.13.1"
+
   },
   "config": {
     "commitizen": {
diff --git a/packages/aura-language-server/jest.config.js b/packages/aura-language-server/jest.config.js
@@ -1,14 +1,16 @@
 module.exports = {
   displayName: 'unit',
   transform: {
-      ".ts": "ts-jest"
-    },
-    testRegex: 'src/.*(\\.|/)(test|spec)\\.(ts|js)$',
-    moduleFileExtensions: [
-      "ts",
-      "js",
-      "json"
-    ],
-    setupFilesAfterEnv: ["jest-extended"],
-    testURL: "http://localhost"
+    ".ts": "ts-jest"
+  },
+  testRegex: 'src/.*(\\.|/)(test|spec)\\.(ts|js)$',
+  moduleFileExtensions: [
+    "ts",
+    "js",
+    "json"
+  ],
+  setupFilesAfterEnv: ["jest-extended"],
+  testEnvironmentOptions: {
+    url: 'http://localhost/',
+  }
 };
diff --git a/packages/aura-language-server/package.json b/packages/aura-language-server/package.json
@@ -33,7 +33,7 @@
     "acorn-walk": "^6.0.0",
     "change-case": "^3.1.0",
     "enhanced-resolve": "^2.2.2",
-    "fs-extra": "^5.0.0",
+    "fs-extra": "^11.3.0",
     "line-column": "^1.0.2",
     "minimatch": "^3.0.4",
     "properties": "^1.2.1",
@@ -46,24 +46,24 @@
   "devDependencies": {
     "@jest/reporters": "^29.7.0",
     "@types/babel-types": "^7.0.8",
-    "@types/fs-extra": "^5.0.4",
+    "@types/fs-extra": "^11.0.4",
     "@types/glob": "^7.1.3",
-    "@types/jest": "^29.5.0",
-    "@types/mock-fs": "^4.10.0",
-    "@types/node": "^18.11.0",
-    "@types/shelljs": "^0.8.8",
+    "@types/jest": "^29.5.14",
+    "@types/mock-fs": "^4.13.4",
+    "@types/node": "^20.0.0",
+    "@types/shelljs": "^0.8.15",
     "babel-types": "^6.26.0",
     "eslint": "^7.7.0",
     "glob": "^7.1.6",
     "husky": "^4.2.5",
-    "jest": "^29.5.0",
+    "jest": "^29.7.0",
     "jest-extended": "^0.11.5",
     "lint-staged": "^10.2.11",
-    "mock-fs": "^4.11.0",
+    "mock-fs": "^5.5.0",
     "npm-run": "^5.0.1",
     "prettier": "^2.0.5",
-    "shelljs": "^0.8.4",
-    "ts-jest": "^29.1.0",
+    "shelljs": "^0.8.5",
+    "ts-jest": "^29.2.6",
     "tsc-transpile-only": "0.0.3",
     "typescript": "5.0.4"
   }
diff --git a/packages/aura-language-server/typings/chokidar.d.ts b/packages/aura-language-server/typings/chokidar.d.ts
@@ -0,0 +1,8 @@
+import 'chokidar';
+
+declare module 'chokidar' {
+    interface FSWatcher {
+        ref(): this;
+        unref(): this;
+    }
+}
diff --git a/packages/lightning-lsp-common/jest.config.js b/packages/lightning-lsp-common/jest.config.js
@@ -1,14 +1,16 @@
 module.exports = {
-    displayName: 'unit',
-    transform: {
-        ".ts": "ts-jest"
-      },
-      testRegex: 'src/.*(\\.|/)(test|spec)\\.(ts|js)$',
-      moduleFileExtensions: [
-        "ts",
-        "js",
-        "json"
-      ],
-      setupFilesAfterEnv: ["<rootDir>/jest/matchers.ts", "jest-extended"],
-      testURL: "http://localhost"
+  displayName: 'unit',
+  transform: {
+    ".ts": "ts-jest"
+  },
+  testRegex: 'src/.*(\\.|/)(test|spec)\\.(ts|js)$',
+  moduleFileExtensions: [
+    "ts",
+    "js",
+    "json"
+  ],
+  setupFilesAfterEnv: ["<rootDir>/jest/matchers.ts", "jest-extended"],
+  testEnvironmentOptions: {
+    url: 'http://localhost/',
+  }
 };
diff --git a/packages/lightning-lsp-common/package.json b/packages/lightning-lsp-common/package.json
@@ -26,7 +26,7 @@
   "dependencies": {
     "decamelize": "^2.0.0",
     "deep-equal": "^1.0.1",
-    "fs-extra": "^5.0.0",
+    "fs-extra": "^11.3.0",
     "glob": "^7.1.6",
     "jsonc-parser": "^2.2.1",
     "lodash.template": "^4.4.0",
@@ -39,31 +39,31 @@
   },
   "devDependencies": {
     "@jest/reporters": "^29.7.0",
-    "@lwc/engine-dom": "2.37.3",
-    "@salesforce/apex": "0.0.12",
+    "@lwc/engine-dom": "8.16.0",
+    "@salesforce/apex": "0.0.21",
     "@types/decamelize": "^1.2.0",
     "@types/deep-equal": "^1.0.1",
-    "@types/fs-extra": "^5.0.4",
+    "@types/fs-extra": "^11.0.4",
     "@types/glob": "^7.1.3",
-    "@types/jest": "^29.5.0",
+    "@types/jest": "^29.5.14",
     "@types/lodash": "^4.14.119",
     "@types/lodash.template": "^4.4.4",
-    "@types/mock-fs": "^4.10.0",
+    "@types/mock-fs": "^4.13.4",
     "@types/semver": "^5.5.0",
-    "@types/shelljs": "^0.8.1",
+    "@types/shelljs": "^0.8.15",
     "@types/tmp": "^0.1.0",
     "find-node-modules": "^1.0.4",
     "findup-sync": "^3.0.0",
     "husky": "^4.2.5",
-    "jest": "^29.5.0",
+    "jest": "^29.7.0",
     "jest-extended": "^0.11.5",
     "lint-staged": "^10.2.11",
     "lwc": "2.37.3",
-    "mock-fs": "^4.11.0",
+    "mock-fs": "^5.5.0",
     "prettier": "^2.0.5",
-    "shelljs": "^0.8.3",
+    "shelljs": "^0.8.5",
     "tmp": "^0.0.33",
-    "ts-jest": "^29.1.0",
+    "ts-jest": "^29.2.6",
     "typescript": "5.0.4"
   }
 }
diff --git a/packages/lightning-lsp-common/src/__tests__/context.test.ts b/packages/lightning-lsp-common/src/__tests__/context.test.ts
@@ -209,7 +209,7 @@ it('configureSfdxProject()', async () => {
     expect(join(sfdxTypingsPath, 'engine.d.ts')).toExist();
     expect(join(sfdxTypingsPath, 'apex.d.ts')).toExist();
     const schemaContents = fs.readFileSync(join(sfdxTypingsPath, 'schema.d.ts'), 'utf8');
-    expect(schemaContents).toContain('declare module "@salesforce/schema" {');
+    expect(schemaContents).toContain(`declare module '@salesforce/schema' {`);
     const apexContents = fs.readFileSync(join(sfdxTypingsPath, 'apex.d.ts'), 'utf8');
     expect(apexContents).not.toContain('declare type');
 });
diff --git a/packages/lightning-lsp-common/typings/chokidar.d.ts b/packages/lightning-lsp-common/typings/chokidar.d.ts
@@ -0,0 +1,8 @@
+import 'chokidar';
+
+declare module 'chokidar' {
+    interface FSWatcher {
+        ref(): this;
+        unref(): this;
+    }
+}
diff --git a/packages/lwc-language-server/jest.config.js b/packages/lwc-language-server/jest.config.js
@@ -1,14 +1,16 @@
 module.exports = {
-    displayName: 'unit',
-    transform: {
-        ".ts": "ts-jest"
-      },
-      testRegex: 'src/.*(\\.|/)(test|spec)\\.(ts|js)$',
-      moduleFileExtensions: [
-        "ts",
-        "js",
-        "json"
-      ],
-      setupFilesAfterEnv: ["<rootDir>/jest/matchers.ts", "jest-extended"],
-      testURL: "http://localhost"
+  displayName: 'unit',
+  transform: {
+    ".ts": "ts-jest"
+  },
+  testRegex: 'src/.*(\\.|/)(test|spec)\\.(ts|js)$',
+  moduleFileExtensions: [
+    "ts",
+    "js",
+    "json"
+  ],
+  setupFilesAfterEnv: ["<rootDir>/jest/matchers.ts", "jest-extended"],
+  testEnvironmentOptions: {
+    url: 'http://localhost/',
+  }
 };
diff --git a/packages/lwc-language-server/package.json b/packages/lwc-language-server/package.json
@@ -26,24 +26,23 @@
     "package": "yarn pack"
   },
   "dependencies": {
-    "@lwc/compiler": "2.50.0",
-    "@lwc/engine-dom": "2.50.0",
-    "@lwc/errors": "2.50.0",
-    "@lwc/metadata": "2.50.0-0",
-    "@lwc/sfdc-compiler-utils": "2.50.0-0",
-    "@lwc/template-compiler": "2.50.0",
-    "@salesforce/apex": "0.0.12",
-    "@salesforce/label": "0.0.12",
+    "@lwc/compiler": "8.16.0",
+    "@lwc/engine-dom": "8.16.0",
+    "@lwc/metadata": "12.2.0",
+    "@lwc/sfdc-compiler-utils": "12.2.0",
+    "@lwc/template-compiler": "8.16.0",
+    "@salesforce/apex": "0.0.21",
+    "@salesforce/label": "0.0.21",
     "@salesforce/lightning-lsp-common": "4.12.2",
-    "@salesforce/resourceurl": "0.0.12",
-    "@salesforce/schema": "0.0.12",
-    "@salesforce/user": "0.0.12",
+    "@salesforce/resourceurl": "0.0.21",
+    "@salesforce/schema": "0.0.21",
+    "@salesforce/user": "0.0.21",
     "babel-core": "7.0.0-bridge.0",
     "camelcase": "^6.0.0",
     "change-case": "^4.1.1",
     "comment-parser": "^0.7.6",
-    "fast-glob": "^3.2.4",
-    "fs-extra": "^5.0.0",
+    "fast-glob": "^3.3.3",
+    "fs-extra": "^11.3.0",
     "normalize-path": "^3.0.0",
     "properties": "^1.2.1",
     "vscode-html-languageservice": "^3.1.0",
@@ -57,21 +56,21 @@
     "@komaci/types": "^246.0.10",
     "@lwc/old-compiler": "npm:@lwc/compiler@0.34.8",
     "@types/babel-types": "^7.0.8",
-    "@types/fs-extra": "^5.0.4",
+    "@types/fs-extra": "^11.0.4",
     "@types/glob": "^7.1.3",
-    "@types/jest": "^29.5.0",
-    "@types/node": "^18.11.0",
+    "@types/jest": "^29.5.14",
+    "@types/node": "^20.0.0",
     "@types/normalize-path": "^3.0.2",
     "@types/xml2js": "^0.4.5",
     "babel-types": "^6.26.0",
     "eol": "^0.9.1",
     "glob": "^7.1.6",
     "husky": "^4.2.5",
-    "jest": "^29.5.0",
+    "jest": "^29.7.0",
     "jest-extended": "^0.11.5",
     "lint-staged": "^10.2.11",
     "prettier": "^2.0.5",
-    "ts-jest": "^29.1.0",
+    "ts-jest": "^29.2.6",
     "typescript": "5.0.4"
   }
 }
diff --git a/packages/lwc-language-server/src/__tests__/lwc-server.test.ts b/packages/lwc-language-server/src/__tests__/lwc-server.test.ts
@@ -415,7 +415,6 @@ describe('handlers', () => {
 
                 // Create files after initialized
                 const watchedFilePath = path.resolve(watchedFileDir, `newlyAddedFile${ext}`);
-                console.log(watchedFilePath);
                 fsExtra.createFileSync(watchedFilePath);
 
                 const didChangeWatchedFilesParams: DidChangeWatchedFilesParams = {
diff --git a/packages/lwc-language-server/src/javascript/__tests__/compiler.test.ts b/packages/lwc-language-server/src/javascript/__tests__/compiler.test.ts
@@ -70,7 +70,6 @@ it('returns empty metadata for a script without a clear main component class', a
 
 it('returns metadata for a script with one component class, even when not exported', async () => {
     const result = await compileSource(codeWithoutDefaultExportSingleClass, 'foo.js');
-    console.log(result);
     expect(result.metadata?.decorators).toHaveLength(1);
     expect(result.metadata?.classMembers).toHaveLength(1);
     expect(result.metadata?.exports).toHaveLength(0);
@@ -146,6 +145,7 @@ it('mapLwcMetadataToInternal returns expected javascript metadata', async () =>
             fileName: 'metadata.js',
             source: content,
         }],
+        npmModuleMapping: {}
     };
 
     const modernMetadata = collectBundleMetadata(options);
diff --git a/packages/lwc-language-server/src/javascript/__tests__/type-mapping.test.ts b/packages/lwc-language-server/src/javascript/__tests__/type-mapping.test.ts
@@ -20,7 +20,7 @@ it('can map new metadata to old metadata', async () => {
                 fileName: 'metadata.js',
                 source: content,
             },
-        ],
+        ], npmModuleMapping: {}
     };
 
     const modernMetadata = collectBundleMetadata(newMetadataOpts);
@@ -51,7 +51,7 @@ it('Should handle mapping when there is a property with only a setter', async ()
                 fileName: 'nogetter.js',
                 source: content,
             },
-        ],
+        ], npmModuleMapping: {}
     };
 
     const modernMetadata = collectBundleMetadata(newMetadataOpts);
diff --git a/packages/lwc-language-server/src/javascript/compiler.ts b/packages/lwc-language-server/src/javascript/compiler.ts
@@ -5,13 +5,11 @@ import { Diagnostic, DiagnosticSeverity, Location, Position, Range, TextDocument
 import { URI } from 'vscode-uri';
 import { DIAGNOSTIC_SOURCE, MAX_32BIT_INTEGER } from '../constants';
 import { BundleConfig, ScriptFile, collectBundleMetadata } from '@lwc/metadata';
-import { CompilerError } from '@lwc/errors';
 import { transformSync } from '@lwc/compiler';
 import { mapLwcMetadataToInternal } from './type-mapping';
 import { ClassMember, Metadata } from '../decorators';
 import { AttributeInfo, Decorator as DecoratorType, MemberType } from '@salesforce/lightning-lsp-common';
 import commentParser from 'comment-parser';
-import { CompilerDiagnostic } from '@lwc/errors';
 
 export interface CompilerResult {
     diagnostics?: Diagnostic[]; // NOTE: vscode Diagnostic, not lwc Diagnostic
@@ -149,6 +147,7 @@ export async function compileSource(source: string, fileName = 'foo.js'): Promis
                 source,
             },
         ],
+        npmModuleMapping: {}
     };
     const modernMetadata = collectBundleMetadata(options);
     if (modernMetadata.diagnostics.length) {
diff --git a/packages/lwc-language-server/src/template/linter.ts b/packages/lwc-language-server/src/template/linter.ts
diff --git a/packages/lwc-language-server/typings/chokidar.d.ts b/packages/lwc-language-server/typings/chokidar.d.ts
diff --git a/test-workspaces/standard-workspace/package.json b/test-workspaces/standard-workspace/package.json
diff --git a/yarn.lock b/yarn.lock
