Open
Description
I have noticed two issues around type parameters:
- Function type parameters get spaces
- Utility functions such as
$NonMaybeType
and indexed accessor
Issue 1
When using a React state hook I want to explicitly type the state property useState<?string>(null)
. This is being formatted as useState < ?string > (null);
by the plugin. This causes no linting warnings or errors based on recommended settings.
Issue 2
When using $NonMaybeType
with indexed types I get a trailing space added $NonMaybeType<SomeType['someNestedArray'][0]>
comes out like $NonMaybeType<SomeType['someNestedArray'][0] >
. This now throws a linting warning (recommended settings) that the generic parameter should not have trailing spaces.
I would love to contribute, if I have time to take a look. Let me know if this is expected behaviour.
Metadata
Metadata
Assignees
Labels
No labels
Activity
Brianzchen commentedon Jan 5, 2022
Thanks for submitting the issue. Happy for you to raise some fixes if they make sense. I haven't come across this issue myself probably because I don't use those rules.
But as I'm trying to test this issue though it looks like the rule doesn't even work on my environment and I have no clue why, might be some other issues in this rule after all.
But if you can figure out what's wrong with your usage happy for you to raise a PR.
genericSpacing
to cover funtion annotations #25hsimah commentedon Jan 5, 2022
I created a new rule
type-annotation-spacing
and raised a PR. This was the most complex linting rule I've authored, so it may need some refinement.