Skip to content

Commit ae8fb3e

Browse files
committed
Explicitly mark destructors with override (#13212)
Summary: I saw these compiler warnings while preparing for the 9.10 release: ```cpp '~CompactOnDeletionCollectorFactory' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override] '~CompactForTieringCollectorFactory' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override] ``` This code is from a while ago so I assume that this CI check has been failing for quite some time. We should still clean this up to avoid confusion in the future. Pull Request resolved: #13212 Test Plan: Existing CI checks should pass, and we should not see this CI check failure the next time we try to make a release/patch. Reviewed By: jaykorean Differential Revision: D67287794 Pulled By: archang19 fbshipit-source-id: a11230a919c0b7ef21a7219bf05f567d3d44b2d1
1 parent 6e8dc74 commit ae8fb3e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/rocksdb/utilities/table_properties_collectors.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class CompactOnDeletionCollectorFactory
3333
size_t deletion_trigger,
3434
double deletion_ratio);
3535

36-
~CompactOnDeletionCollectorFactory() {}
36+
~CompactOnDeletionCollectorFactory() override {}
3737

3838
TablePropertiesCollector* CreateTablePropertiesCollector(
3939
TablePropertiesCollectorFactory::Context context) override;
@@ -108,7 +108,7 @@ class CompactForTieringCollectorFactory
108108
// for what entry is eligible.
109109
CompactForTieringCollectorFactory(double compaction_trigger_ratio);
110110

111-
~CompactForTieringCollectorFactory() {}
111+
~CompactForTieringCollectorFactory() override {}
112112

113113
TablePropertiesCollector* CreateTablePropertiesCollector(
114114
TablePropertiesCollectorFactory::Context context) override;

0 commit comments

Comments
 (0)