Skip to content

Commit a3a665f

Browse files
jbower-fbfacebook-github-bot
authored andcommitted
Fix handling of -j in autoconf builder
Summary: The *string* `"false"`, which was being returned by default, will be interpreted as truthy. So we were never getting the `-j` arg on the `make` command. Should be a nice little speed boost for some builds. Reviewed By: chadaustin Differential Revision: D78819581 fbshipit-source-id: a1b57f17185d189df25e913e06bcf71f8f540053
1 parent 180d1c8 commit a3a665f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

build/fbcode_builder/getdeps/builder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -443,8 +443,8 @@ def _build(self, reconfigure) -> None:
443443
self._check_cmd(["autoreconf", "-ivf"], cwd=self.src_dir, env=env)
444444
configure_cmd = [configure_path, "--prefix=" + self.inst_dir] + self.args
445445
self._check_cmd(configure_cmd, env=env)
446-
only_install = self.manifest.get("build", "only_install", "false", ctx=self.ctx)
447-
if not only_install:
446+
only_install = self.manifest.get("build", "only_install", ctx=self.ctx)
447+
if not only_install or only_install.lower() == "false":
448448
self._check_cmd([self._make_binary, "-j%s" % self.num_jobs], env=env)
449449
self._check_cmd([self._make_binary, "install"], env=env)
450450

0 commit comments

Comments
 (0)