Skip to content

Commit 566bea2

Browse files
authored
Relocate utils/weekday.py to standard provider (apache#47892)
The weekday util has been created and used exclusively by the weekday operator/sensors that were already relocated to standard provider.
1 parent 53ec90c commit 566bea2

File tree

10 files changed

+32
-10
lines changed

10 files changed

+32
-10
lines changed

airflow/example_dags/example_bash_decorator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222
from airflow.decorators import dag, task
2323
from airflow.exceptions import AirflowSkipException
2424
from airflow.providers.standard.operators.empty import EmptyOperator
25+
from airflow.providers.standard.utils.weekday import WeekDay
2526
from airflow.sdk import chain
2627
from airflow.utils.trigger_rule import TriggerRule
27-
from airflow.utils.weekday import WeekDay
2828

2929

3030
@dag(schedule=None, start_date=pendulum.datetime(2023, 1, 1, tz="UTC"), catchup=False)

airflow/example_dags/example_branch_day_of_week_operator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
from airflow.models.dag import DAG
2727
from airflow.providers.standard.operators.empty import EmptyOperator
2828
from airflow.providers.standard.operators.weekday import BranchDayOfWeekOperator
29-
from airflow.utils.weekday import WeekDay
29+
from airflow.providers.standard.utils.weekday import WeekDay
3030

3131
with DAG(
3232
dag_id="example_weekday_branch_operator",

airflow/example_dags/example_sensors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
from airflow.providers.standard.sensors.time import TimeSensor, TimeSensorAsync
3030
from airflow.providers.standard.sensors.time_delta import TimeDeltaSensor, TimeDeltaSensorAsync
3131
from airflow.providers.standard.sensors.weekday import DayOfWeekSensor
32+
from airflow.providers.standard.utils.weekday import WeekDay
3233
from airflow.utils.trigger_rule import TriggerRule
33-
from airflow.utils.weekday import WeekDay
3434

3535

3636
# [START example_callables]

newsfragments/47892.significant.rst

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
Relocate utils.weekday from core to standard provider
2+
3+
Removed module ``airflow.utils.weekday`` removed. Please use ``from airflow.providers.standard.utils.weekday`` instead.
4+
5+
* Types of change
6+
7+
* [x] Dag changes
8+
* [ ] Config changes
9+
* [ ] API changes
10+
* [ ] CLI changes
11+
* [ ] Behaviour changes
12+
* [ ] Plugin changes
13+
* [ ] Dependency changes
14+
* [ ] Code interface changes
15+
16+
* Migration rules needed
17+
18+
* ruff
19+
20+
* AIR303
21+
22+
* [x] ``airflow.utils.weekday`` → ``airflow.providers.standard.utils.weekday``

providers/standard/src/airflow/providers/standard/operators/weekday.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
from typing import TYPE_CHECKING
2222

2323
from airflow.providers.standard.operators.branch import BaseBranchOperator
24+
from airflow.providers.standard.utils.weekday import WeekDay
2425
from airflow.utils import timezone
25-
from airflow.utils.weekday import WeekDay
2626

2727
if TYPE_CHECKING:
2828
try:
@@ -63,7 +63,7 @@ class BranchDayOfWeekOperator(BaseBranchOperator):
6363
.. code-block:: python
6464
6565
# import WeekDay Enum
66-
from airflow.utils.weekday import WeekDay
66+
from airflow.providers.standard.utils.weekday import WeekDay
6767
from airflow.providers.standard.operators.empty import EmptyOperator
6868
from airflow.operators.weekday import BranchDayOfWeekOperator
6969

providers/standard/src/airflow/providers/standard/sensors/weekday.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
from collections.abc import Iterable
2121
from typing import TYPE_CHECKING
2222

23+
from airflow.providers.standard.utils.weekday import WeekDay
2324
from airflow.sensors.base import BaseSensorOperator
2425
from airflow.utils import timezone
25-
from airflow.utils.weekday import WeekDay
2626

2727
if TYPE_CHECKING:
2828
try:
@@ -54,7 +54,7 @@ class DayOfWeekSensor(BaseSensorOperator):
5454
**Example** (with :class:`~airflow.utils.weekday.WeekDay` enum): ::
5555
5656
# import WeekDay Enum
57-
from airflow.utils.weekday import WeekDay
57+
from airflow.providers.standard.utils.weekday import WeekDay
5858
5959
weekend_check = DayOfWeekSensor(
6060
task_id="weekend_check",

providers/standard/tests/unit/standard/operators/test_weekday.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@
2828
from airflow.providers.standard.operators.empty import EmptyOperator
2929
from airflow.providers.standard.operators.weekday import BranchDayOfWeekOperator
3030
from airflow.providers.standard.utils.skipmixin import XCOM_SKIPMIXIN_FOLLOWED, XCOM_SKIPMIXIN_KEY
31+
from airflow.providers.standard.utils.weekday import WeekDay
3132
from airflow.providers.standard.version_compat import AIRFLOW_V_3_0_PLUS
3233
from airflow.timetables.base import DataInterval
3334
from airflow.utils import timezone
3435
from airflow.utils.session import create_session
3536
from airflow.utils.state import State
36-
from airflow.utils.weekday import WeekDay
3737

3838
if AIRFLOW_V_3_0_PLUS:
3939
from airflow.models.xcom import XComModel as XCom

providers/standard/tests/unit/standard/sensors/test_weekday.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
from airflow.models import DagBag
2626
from airflow.models.dag import DAG
2727
from airflow.providers.standard.sensors.weekday import DayOfWeekSensor
28+
from airflow.providers.standard.utils.weekday import WeekDay
2829
from airflow.providers.standard.version_compat import AIRFLOW_V_3_0_PLUS
2930
from airflow.utils import timezone
3031
from airflow.utils.timezone import datetime
31-
from airflow.utils.weekday import WeekDay
3232

3333
from tests_common.test_utils import db
3434

tests/utils/test_weekday.py renamed to providers/standard/tests/unit/standard/utils/test_weekday.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
import pytest
2323

24-
from airflow.utils.weekday import WeekDay
24+
from airflow.providers.standard.utils.weekday import WeekDay
2525

2626

2727
class TestWeekDay:

0 commit comments

Comments
 (0)