Enhance package ping functionality to update repository metadata and advisories based on user agent

Author: andrew

app/controllers/api/v1/packages_controller.rb

@@ -233,14 +233,23 @@ def ping
     @package = @registry.packages.find_by_name(params[:id])
     if @package
       @package.sync_async
+      @package.update_repo_metadata_async if request.user_agent&.include?('repos.ecosyste.ms')
+      @package.update_advisories_async if request.user_agent&.include?('advisories.ecosyste.ms')
     else
       @registry.sync_package_async(params[:id])
     end
     render json: { message: 'pong' }
   end
 
   def ping_all
-    Package.repository_url(params[:repository_url]).limit(1000).each(&:sync_async) unless params[:repository_url].nil?
+    unless params[:repository_url].nil?
+      packages = Package.repository_url(params[:repository_url]).limit(1000)
+      packages.each do |package|
+        package.sync_async
+        package.update_repo_metadata_async if request.user_agent&.include?('repos.ecosyste.ms')
+        package.update_advisories_async if request.user_agent&.include?('advisories.ecosyste.ms')
+      end
+    end
 
     render json: { message: 'pong' }
   end

test/controllers/api/v1/packages_controller_test.rb

@@ -153,4 +153,110 @@ class ApiV1PackagesControllerTest < ActionDispatch::IntegrationTest
     assert_equal actual_response.length, 1
     assert_equal actual_response.first['name'], @package.name
   end
+
+  test 'ping package' do
+    get ping_api_v1_registry_package_path(registry_id: @registry.name, id: @package.name)
+    assert_response :success
+    
+    actual_response = Oj.load(@response.body)
+    assert_equal actual_response['message'], 'pong'
+  end
+
+  test 'ping package with repos.ecosyste.ms user agent' do
+    # Mock the async methods to verify they're called
+    Package.any_instance.expects(:sync_async).once
+    Package.any_instance.expects(:update_repo_metadata_async).once
+
+    get ping_api_v1_registry_package_path(registry_id: @registry.name, id: @package.name),
+        headers: { 'User-Agent' => 'repos.ecosyste.ms/1.0' }
+    assert_response :success
+    
+    actual_response = Oj.load(@response.body)
+    assert_equal actual_response['message'], 'pong'
+  end
+
+  test 'ping package with different user agent' do
+    # Mock the async methods to verify sync is called but not update_repo_metadata_async
+    Package.any_instance.expects(:sync_async).once
+    Package.any_instance.expects(:update_repo_metadata_async).never
+
+    get ping_api_v1_registry_package_path(registry_id: @registry.name, id: @package.name),
+        headers: { 'User-Agent' => 'other-service/1.0' }
+    assert_response :success
+    
+    actual_response = Oj.load(@response.body)
+    assert_equal actual_response['message'], 'pong'
+  end
+
+  test 'ping nonexistent package' do
+    Registry.any_instance.expects(:sync_package_async).with('nonexistent').once
+
+    get ping_api_v1_registry_package_path(registry_id: @registry.name, id: 'nonexistent')
+    assert_response :success
+    
+    actual_response = Oj.load(@response.body)
+    assert_equal actual_response['message'], 'pong'
+  end
+
+  test 'ping all packages by repository url' do
+    @package.update(repository_url: 'https://github.com/rust-random/rand')
+    
+    Package.any_instance.expects(:sync_async).once
+    Package.any_instance.expects(:update_repo_metadata_async).never
+
+    get ping_api_v1_packages_path(repository_url: 'https://github.com/rust-random/rand')
+    assert_response :success
+    
+    actual_response = Oj.load(@response.body)
+    assert_equal actual_response['message'], 'pong'
+  end
+
+  test 'ping all packages by repository url with repos.ecosyste.ms user agent' do
+    @package.update(repository_url: 'https://github.com/rust-random/rand')
+    
+    Package.any_instance.expects(:sync_async).once
+    Package.any_instance.expects(:update_repo_metadata_async).once
+
+    get ping_api_v1_packages_path(repository_url: 'https://github.com/rust-random/rand'),
+        headers: { 'User-Agent' => 'repos.ecosyste.ms/1.0' }
+    assert_response :success
+    
+    actual_response = Oj.load(@response.body)
+    assert_equal actual_response['message'], 'pong'
+  end
+
+  test 'ping all packages without repository url' do
+    get ping_api_v1_packages_path
+    assert_response :success
+    
+    actual_response = Oj.load(@response.body)
+    assert_equal actual_response['message'], 'pong'
+  end
+
+  test 'ping package with advisories.ecosyste.ms user agent' do
+    # Mock the async methods to verify they're called
+    Package.any_instance.expects(:sync_async).once
+    Package.any_instance.expects(:update_advisories_async).once
+
+    get ping_api_v1_registry_package_path(registry_id: @registry.name, id: @package.name),
+        headers: { 'User-Agent' => 'advisories.ecosyste.ms/1.0' }
+    assert_response :success
+    
+    actual_response = Oj.load(@response.body)
+    assert_equal actual_response['message'], 'pong'
+  end
+
+  test 'ping all packages by repository url with advisories.ecosyste.ms user agent' do
+    @package.update(repository_url: 'https://github.com/rust-random/rand')
+    
+    Package.any_instance.expects(:sync_async).once
+    Package.any_instance.expects(:update_advisories_async).once
+
+    get ping_api_v1_packages_path(repository_url: 'https://github.com/rust-random/rand'),
+        headers: { 'User-Agent' => 'advisories.ecosyste.ms/1.0' }
+    assert_response :success
+    
+    actual_response = Oj.load(@response.body)
+    assert_equal actual_response['message'], 'pong'
+  end
 end