Multi-root Workspaces

[dsanders11]

Current form of the extension is built on the assumption that there's a single workspace folder, and that it's the Electron checkout (either src or src/electron). Things "Mostly Work" if you add a second workspace folder after, as long as the first workspace folder has the Electron checkout.

Provide better support for finding an Electron checkout that's not the first workspace folder. To avoid unnecessary complexity, add a constraint that there can only be one Electron checkout workspace folder. Perhaps allow a special case where you have both src and src/electron as separate workspace folders.

[khushi205]

Hey! 👋 I'd love to contribute to this improvement. From what I understand, the current logic assumes the Electron checkout is always the first workspace folder, which can cause issues if it's not.

My thought is to update the detection logic to scan all workspace folders and identify the Electron checkout based on known patterns (e.g., presence of electron/ folder structure or specific files like electron.gyp, etc.).

To keep it simple, I’d add a constraint to enforce only one Electron checkout across the folders, and possibly support both src and src/electron as long as they’re clearly identified.

Let me know if that sounds aligned with what you're looking for—I’m happy to put together a PR!

[khushi205]

@dsanders11 please sir give me a chance

[dsanders11]

@khushi205, thanks for the offer, but I'm already working on this.

[khushi205]

I just want to contribute sir

…

On Mon, 14 Apr 2025 at 09:58, David Sanders ***@***.***> wrote: @khushi205 <https://github.com/khushi205>, thanks for the offer, but I'm already working on this. — Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BK4RJPOXTD3V4HAUGYUMIB32ZM2QTAVCNFSM6AAAAAB2554POCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBQGQ2DIMBRHE> . You are receiving this because you were mentioned.Message ID: ***@***.***> *dsanders11* left a comment (dsanders11/vscode-electron-build-tools#28) <#28 (comment)> @khushi205 <https://github.com/khushi205>, thanks for the offer, but I'm already working on this. — Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BK4RJPOXTD3V4HAUGYUMIB32ZM2QTAVCNFSM6AAAAAB2554POCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBQGQ2DIMBRHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>