chore: update dev dependencies and clean up lint

Author: dsanders11

.eslintrc.json

@@ -0,0 +1 @@
+yarn commitlint --edit $1

.husky/commit-msg

@@ -0,0 +1 @@
+npx lint-staged

.husky/pre-commit

@@ -13,7 +13,7 @@ const exports: typeof typescript = {
         const output = service.getEmitOutput(
           fileName,
           emitOnlyDtsFiles,
-          forceDtsEmit
+          forceDtsEmit,
         );
         contentMap.set(fileName, output.outputFiles[1].text);
 

electron/electron-build-tools-typescript.ts

@@ -14,20 +14,15 @@ process.once("uncaughtException", (err) => {
 // @ts-ignore
 import { app } from "electron";
 
-const { SourceMapConsumer } = require(path.resolve(
-  process.cwd(),
-  "node_modules",
-  "source-map"
-));
-const { retrieveSourceMap } = require(path.resolve(
-  process.cwd(),
-  "node_modules",
-  "source-map-support"
-));
-const { getFileContent } = require(path.resolve(
-  __dirname,
-  "electron-build-tools-typescript"
-));
+const { SourceMapConsumer } = require(
+  path.resolve(process.cwd(), "node_modules", "source-map"),
+);
+const { retrieveSourceMap } = require(
+  path.resolve(process.cwd(), "node_modules", "source-map-support"),
+);
+const { getFileContent } = require(
+  path.resolve(__dirname, "electron-build-tools-typescript"),
+);
 
 const sourceMapConsumers = new Map<string, any>();
 
@@ -127,12 +122,9 @@ app
     require(path.resolve(process.cwd(), "node_modules", "ts-node/register"));
 
     // Don't load Mocha until after setting up ts-node
-    const Mocha = require(path.resolve(
-      process.cwd(),
-      "spec",
-      "node_modules",
-      "mocha"
-    ));
+    const Mocha = require(
+      path.resolve(process.cwd(), "spec", "node_modules", "mocha"),
+    );
 
     const mocha: MochaType = new Mocha({
       ui: path.resolve(__dirname, "mocha-interface.js"),
@@ -164,7 +156,7 @@ app
             await mocha.loadFiles();
             const parsedSuites = parseTestSuites(mocha.suite);
             socket.write(JSON.stringify(parsedSuites, undefined, 4), () =>
-              process.exit(0)
+              process.exit(0),
             );
           } catch (err: any) {
             console.error(err);

electron/listMochaTests.ts

@@ -6,28 +6,32 @@ import * as path from "path";
 import type { Func, Suite, Test as TestType } from "mocha";
 import type { CommonFunctions } from "mocha/lib/interfaces/common";
 
-const Test: typeof TestType = require(path.resolve(
-  process.env["ELECTRON_ROOT"]!,
-  "spec",
-  "node_modules",
-  "mocha",
-  "lib",
-  "test"
-));
+const Test: typeof TestType = require(
+  path.resolve(
+    process.env["ELECTRON_ROOT"]!,
+    "spec",
+    "node_modules",
+    "mocha",
+    "lib",
+    "test",
+  ),
+);
 
 function Interface(suite: Suite) {
   const suites = [suite];
 
   suite.on("pre-require", (context, file, mocha) => {
-    const common: CommonFunctions = require(path.resolve(
-      process.env["ELECTRON_ROOT"]!,
-      "spec",
-      "node_modules",
-      "mocha",
-      "lib",
-      "interfaces",
-      "common"
-    ))(suites, context, mocha);
+    const common: CommonFunctions = require(
+      path.resolve(
+        process.env["ELECTRON_ROOT"]!,
+        "spec",
+        "node_modules",
+        "mocha",
+        "lib",
+        "interfaces",
+        "common",
+      ),
+    )(suites, context, mocha);
 
     context.before = common.before;
     context.after = common.after;
@@ -42,7 +46,7 @@ function Interface(suite: Suite) {
      */
     (context.describe as any) = (context.context as any) = (
       title: string,
-      fn: (this: Suite) => void
+      fn: (this: Suite) => void,
     ) => {
       const suite = common.suite.create({ title, file, fn });
 
@@ -72,7 +76,7 @@ function Interface(suite: Suite) {
      */
     (context.describe.only as any) = (
       title: string,
-      fn: (this: Suite) => void
+      fn: (this: Suite) => void,
     ) => {
       const suite = common.suite.only({ title, file, fn });
 
@@ -89,7 +93,7 @@ function Interface(suite: Suite) {
      */
     (context.it as any) = (context.specify as any) = (
       title: string,
-      fn?: Func
+      fn?: Func,
     ) => {
       const suite = suites[0];
       if (suite.isPending()) {

electron/mocha-interface.ts

@@ -3,15 +3,17 @@ import * as path from "path";
 
 import type { reporters, Runner, Test } from "mocha";
 
-const Base: reporters.Base = require(path.resolve(
-  process.env["ELECTRON_ROOT"]!,
-  "spec",
-  "node_modules",
-  "mocha",
-  "lib",
-  "reporters",
-  "base"
-));
+const Base: reporters.Base = require(
+  path.resolve(
+    process.env["ELECTRON_ROOT"]!,
+    "spec",
+    "node_modules",
+    "mocha",
+    "lib",
+    "reporters",
+    "base",
+  ),
+);
 
 // Encode any newlines so we can use newline as a delimeter
 function encodeNewlines(value: string) {
@@ -42,7 +44,7 @@ function Reporter(runner: Runner) {
         JSON.stringify({
           stream: "mocha-test-results",
           data: ["start", { total: runner.total }],
-        })
+        }),
       );
     });
 
@@ -51,7 +53,7 @@ function Reporter(runner: Runner) {
         JSON.stringify({
           stream: "mocha-test-results",
           data: ["test-start", clean(test)],
-        })
+        }),
       );
     });
 
@@ -60,7 +62,7 @@ function Reporter(runner: Runner) {
         JSON.stringify({
           stream: "mocha-test-results",
           data: ["test-end", clean(test)],
-        })
+        }),
       );
     });
 
@@ -69,7 +71,7 @@ function Reporter(runner: Runner) {
         JSON.stringify({
           stream: "mocha-test-results",
           data: ["pass", clean(test)],
-        })
+        }),
       );
     });
 
@@ -78,7 +80,7 @@ function Reporter(runner: Runner) {
         JSON.stringify({
           stream: "mocha-test-results",
           data: ["pending", clean(test)],
-        })
+        }),
       );
     });
 
@@ -87,7 +89,10 @@ function Reporter(runner: Runner) {
       (output as any).err = err;
       (output as any).stack = err.stack || null;
       writeToSocket(
-        JSON.stringify({ stream: "mocha-test-results", data: ["fail", output] })
+        JSON.stringify({
+          stream: "mocha-test-results",
+          data: ["fail", output],
+        }),
       );
     });
 
@@ -97,7 +102,7 @@ function Reporter(runner: Runner) {
           stream: "mocha-test-results",
           // @ts-ignore
           data: ["end", this.stats],
-        })
+        }),
       );
     });
   });

electron/mocha-reporter.ts

@@ -6,11 +6,9 @@ import * as path from "path";
 
 export async function setupSpecRunner(electronRoot: string) {
   const fs = require(path.resolve(electronRoot, "node_modules", "fs-extra"));
-  const { hashElement } = require(path.resolve(
-    electronRoot,
-    "node_modules",
-    "folder-hash"
-  ));
+  const { hashElement } = require(
+    path.resolve(electronRoot, "node_modules", "folder-hash"),
+  );
 
   const SCRIPT_DIR = path.resolve(electronRoot, "script");
 
@@ -28,11 +26,11 @@ export async function setupSpecRunner(electronRoot: string) {
         cwd: electronRoot,
         stdio: "inherit",
         shell: true,
-      }
+      },
     );
     if (status !== 0) {
       throw new Error(
-        `Electron typescript definition generation failed with exit code: ${status}.`
+        `Electron typescript definition generation failed with exit code: ${status}.`,
       );
     }
   }
@@ -42,21 +40,21 @@ export async function setupSpecRunner(electronRoot: string) {
       (async () => {
         const hasher = crypto.createHash("SHA256");
         hasher.update(
-          fs.readFileSync(path.resolve(electronRoot, "spec", "package.json"))
+          fs.readFileSync(path.resolve(electronRoot, "spec", "package.json")),
         );
         hasher.update(
-          fs.readFileSync(path.resolve(electronRoot, "spec", "yarn.lock"))
+          fs.readFileSync(path.resolve(electronRoot, "spec", "yarn.lock")),
         );
         hasher.update(
-          fs.readFileSync(path.resolve(SCRIPT_DIR, "spec-runner.js"))
+          fs.readFileSync(path.resolve(SCRIPT_DIR, "spec-runner.js")),
         );
         return hasher.digest("hex");
       })(),
       (async () => {
         const specNodeModulesPath = path.resolve(
           electronRoot,
           "spec",
-          "node_modules"
+          "node_modules",
         );
         if (!fs.existsSync(specNodeModulesPath)) {
           return null;
@@ -80,7 +78,7 @@ export async function setupSpecRunner(electronRoot: string) {
 
     const nodeDir = path.resolve(
       BASE,
-      `out/${utils.getOutDir({ shouldLog: true })}/gen/node_headers`
+      `out/${utils.getOutDir({ shouldLog: true })}/gen/node_headers`,
     );
     const env = {
       ...process.env,
@@ -99,7 +97,7 @@ export async function setupSpecRunner(electronRoot: string) {
         env,
         cwd: dir,
         stdio: "inherit",
-      }
+      },
     );
     if (status !== 0 && !process.env.IGNORE_YARN_INSTALL_ERROR) {
       console.log(`Failed to yarn install in '${dir}'`);

electron/spec-runner.ts

@@ -0,0 +1,48 @@
+// @ts-check
+
+import eslint from '@eslint/js';
+import tseslint from 'typescript-eslint';
+
+export default tseslint.config(
+  eslint.configs.recommended,
+  ...tseslint.configs.recommended,
+  {
+    plugins: {
+      '@typescript-eslint': tseslint.plugin,
+    },
+    languageOptions: {
+      parser: tseslint.parser,
+      parserOptions: {
+        ecmaVersion: 2020,
+        sourceType: 'module',
+      },
+    },
+    rules: {
+      '@typescript-eslint/naming-convention': [
+        'warn',
+        {
+          selector: 'property',
+          format: ['strictCamelCase', 'UPPER_CASE'],
+          leadingUnderscore: 'allow'
+        }
+      ],
+      '@typescript-eslint/no-unused-vars': [
+        'error',
+        {
+          args: 'all',
+          argsIgnorePattern: '^_',
+          caughtErrors: 'all',
+          caughtErrorsIgnorePattern: '^_',
+          destructuredArrayIgnorePattern: '^_',
+          varsIgnorePattern: '^_',
+          ignoreRestSiblings: true
+        }
+      ],
+      curly: 'warn',
+      eqeqeq: 'warn',
+      'no-throw-literal': 'warn',
+      'no-useless-escape': 'warn',
+      semi: 'off'
+    },
+  }
+);