Merge pull request #2425 from ksowa/disable-validators

Added --disable-validators option to odm:schema:update command

Author: malarzm

lib/Doctrine/ODM/MongoDB/Tools/Console/Command/Schema/UpdateCommand.php

@@ -27,15 +27,17 @@ protected function configure()
         $this
             ->setName('odm:schema:update')
             ->addOption('class', 'c', InputOption::VALUE_OPTIONAL, 'Document class to process (default: all classes)')
-            ->setDescription('Update indexes for your documents');
+            ->addOption('disable-validators', null, InputOption::VALUE_NONE, 'Do not update database-level validation rules')
+            ->setDescription('Update indexes and validation rules for your documents');
     }
 
     /**
      * @return int
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        $class = $input->getOption('class');
+        $class            = $input->getOption('class');
+        $updateValidators = ! $input->getOption('disable-validators');
 
         $sm        = $this->getSchemaManager();
         $isErrored = false;
@@ -44,13 +46,19 @@ protected function execute(InputInterface $input, OutputInterface $output)
             if (is_string($class)) {
                 $this->processDocumentIndex($sm, $class, $this->getMaxTimeMsFromInput($input), $this->getWriteConcernFromInput($input));
                 $output->writeln(sprintf('Updated <comment>index(es)</comment> for <info>%s</info>', $class));
-                $this->processDocumentValidator($sm, $class, $this->getMaxTimeMsFromInput($input), $this->getWriteConcernFromInput($input));
-                $output->writeln(sprintf('Updated <comment>validation</comment> for <info>%s</info>', $class));
+
+                if ($updateValidators) {
+                    $this->processDocumentValidator($sm, $class, $this->getMaxTimeMsFromInput($input), $this->getWriteConcernFromInput($input));
+                    $output->writeln(sprintf('Updated <comment>validation</comment> for <info>%s</info>', $class));
+                }
             } else {
                 $this->processIndex($sm, $this->getMaxTimeMsFromInput($input), $this->getWriteConcernFromInput($input));
                 $output->writeln('Updated <comment>indexes</comment> for <info>all classes</info>');
-                $this->processValidators($sm, $this->getMaxTimeMsFromInput($input), $this->getWriteConcernFromInput($input));
-                $output->writeln('Updated <comment>validation</comment> for <info>all classes</info>');
+
+                if ($updateValidators) {
+                    $this->processValidators($sm, $this->getMaxTimeMsFromInput($input), $this->getWriteConcernFromInput($input));
+                    $output->writeln('Updated <comment>validation</comment> for <info>all classes</info>');
+                }
             }
         } catch (Throwable $e) {
             $output->writeln('<error>' . $e->getMessage() . '</error>');

tests/Doctrine/ODM/MongoDB/Tests/Tools/Console/Command/Schema/UpdateCommandTest.php

@@ -53,6 +53,18 @@ public function testProcessValidator(): void
         $this->assertStringContainsString('Updated validation for Documents\SchemaValidated', $output);
     }
 
+    public function testDisabledValidatorProcessing(): void
+    {
+        $this->commandTester->execute(
+            [
+                '--class' => SchemaValidated::class,
+                '--disable-validators' => true,
+            ]
+        );
+        $output = $this->commandTester->getDisplay();
+        $this->assertStringNotContainsString('Updated validation for Documents\SchemaValidated', $output);
+    }
+
     public function testProcessValidators(): void
     {
         // Only load a subset of documents with legit annotations
@@ -62,4 +74,14 @@ public function testProcessValidators(): void
         $output = $this->commandTester->getDisplay();
         $this->assertStringContainsString('Updated validation for all classes', $output);
     }
+
+    public function testDisabledValidatorsProcessing(): void
+    {
+        // Only load a subset of documents with legit annotations
+        $annotationDriver = AnnotationDriver::create(__DIR__ . '/../../../../../../../../Documents/Ecommerce');
+        $this->dm->getConfiguration()->setMetadataDriverImpl($annotationDriver);
+        $this->commandTester->execute(['--disable-validators' => true]);
+        $output = $this->commandTester->getDisplay();
+        $this->assertStringNotContainsString('Updated validation for all classes', $output);
+    }
 }