Use eslint plugin to catch exclusive tests (cypress-io#2194)

On platforms without a decent grep, it seems stop-only does a poor
job of correctly detecting focused tests. There's an eslint plugin
which is much more suitable, use that instead.

While changing eslint config, tidy up the lint commands and fix a
couple of minor issues in files that were not being linted.

Exclude public/ and themes/ folders from lint, cover everything else.

Author: bz2

.eslintignore

@@ -0,0 +1,2 @@
+/public/*
+/themes/*

.eslintrc

@@ -1,6 +1,7 @@
 {
   "plugins": [
-    "cypress"
+    "cypress",
+    "no-only-tests"
   ],
   "extends": [
     "plugin:cypress-dev/general",
@@ -10,5 +11,8 @@
     "es6": true,
     "node": true,
     "cypress/globals": true
+  },
+  "rules": {
+    "no-only-tests/no-only-tests": "warn"
   }
 }

circle.yml

@@ -66,9 +66,8 @@ jobs:
       #
       - run: ls -la
       - run: npm run deps
-      - run: npm run lint
+      - run: npm run lint -- --max-warnings=0
       - run: npm run md-lint
-      - run: npm run stop-only
       - run: npm test
       - run: npm run build
 

lib/tags/assertions.js

@@ -11,16 +11,12 @@ module.exports = function yields (hexo, args) {
   const type = args[0]
   const cmd = `<code>${args[1]}()</code>`
 
-  /* eslint-disable commas */
   const waitAssertions = `${cmd} will automatically wait for assertions you've chained to pass`
 
-  /* eslint-disable commas */
   const retryAssertions = `${cmd} will automatically {% url "retry" retry-ability %} until assertions you've chained all pass`
 
-  /* eslint-disable quotes */
   const exist = `${cmd} will automatically {% url "retry" retry-ability %} until the element(s) {% url 'exist in the DOM' introduction-to-cypress#Default-Assertions %}`
 
-  /* eslint-disable quotes */
   const actionable = `${cmd} will automatically wait for the element to reach an {% url 'actionable state' interacting-with-elements %}`
 
   const render = (str) => {

lib/tags/partial.js

@@ -4,10 +4,11 @@ const rawRender = require('../raw_render')
 
 module.exports = function partial (hexo, fileName) {
   const pathToFile = path.resolve('source', '_partial', `${fileName}.md`)
-  
+
   return new Promise((resolve, reject) => {
     fs.readFile(pathToFile, (err, data) => {
       if (err) reject(err)
+
       resolve(rawRender(hexo, data.toString(), { engine: 'markdown' }))
     })
   })