Skip to content

Upgrade client/spark to use Spark 4.0.0-preview1 #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 16, 2025

Conversation

littlegrasscao
Copy link
Collaborator

@littlegrasscao littlegrasscao commented May 15, 2025

For client and spark build:

  • Upgrade spark version to 4.0.0-preview1
  • Upgrade scala version to 2.13.13
  • Upgrade Java version to 17

Server build is still using spark 3 and java 8

Sun Cao added 6 commits May 15, 2025 10:35
@littlegrasscao littlegrasscao changed the title Fix Spark implicits issue with Delta OSS 4.0 Upgrade client/spark to use Spark 4.0.0 May 16, 2025
@littlegrasscao littlegrasscao changed the title Upgrade client/spark to use Spark 4.0.0 Upgrade client/spark to use Spark 4.0.0-preview1 May 16, 2025
@littlegrasscao littlegrasscao marked this pull request as ready for review May 16, 2025 03:30
Copy link
Collaborator

@linzhou-db linzhou-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and are all the code changes needed for compilation with the new spark version?

@littlegrasscao
Copy link
Collaborator Author

and are all the code changes needed for compilation with the new spark version?

Some codes changes are for compilation.
Some are for making tests passing.

@littlegrasscao
Copy link
Collaborator Author

and are all the code changes needed for compilation with the new spark version?

Some codes changes are for compilation. Some are for making tests passing.

Some tests just fail silently. No error no exception. But the results are wrong. e.g. this limit pushdown.

@littlegrasscao littlegrasscao requested a review from linzhou-db May 16, 2025 17:36
@littlegrasscao littlegrasscao merged commit 5675778 into branch-1.3 May 16, 2025
19 checks passed
littlegrasscao added a commit that referenced this pull request May 21, 2025
* Fix Spark implicits issue with Delta OSS 4.0

* Revert "Fix Spark implicits issue with Delta OSS 4.0"

This reverts commit 9cd1804.

* upgrade spark to 4.0.0-preview1

* fix test

* fix test

* fix test

* fix test

* fix test

---------

Co-authored-by: Sun Cao <[email protected]>
littlegrasscao added a commit that referenced this pull request May 21, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Upgrade client/spark to use Spark 4.0.0-preview1 (#728)

* Fix Spark implicits issue with Delta OSS 4.0

* Revert "Fix Spark implicits issue with Delta OSS 4.0"

This reverts commit 9cd1804.

* upgrade spark to 4.0.0-preview1

* fix test

* fix test

* fix test

* fix test

* fix test

---------

Co-authored-by: Sun Cao <[email protected]>

* Upgrade spark version to staging 4.0.0 for client/spark build (#729)

* Setting version to 4.0.0

* fix compile

* Revert "fix compile"

This reverts commit daa57ce.

* fix compile

* fix compile

* fix compile

* fix compile

* fix compile

* fix limit pushdown

* fix tests

* fix tests

* add case

---------

Co-authored-by: Sun Cao <[email protected]>

---------

Co-authored-by: Sun Cao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants