Support baseURL without /api suffix

Author: tdabasinskas

backstage/backstage.go

@@ -42,7 +42,14 @@ type Client struct {
 // NewClient returns a new Backstage API client. If a nil httpClient is  provided, a new http.Client will be used.
 // To use API methods which require authentication, provide a http.Client that will perform the authentication.
 func NewClient(baseURL string, defaultNamespace string, httpClient *http.Client) (*Client, error) {
-	baseEndpoint, err := url.Parse(strings.TrimSuffix(baseURL, "/"))
+	const apiPath = "/api"
+
+	baseURL = strings.TrimSuffix(baseURL, "/")
+	if !strings.HasSuffix(baseURL, apiPath) {
+		baseURL += apiPath
+	}
+
+	baseEndpoint, err := url.Parse(baseURL)
 	if err != nil {
 		return nil, err
 	}

backstage/backstage_test.go

@@ -28,6 +28,17 @@ func TestNewClient(t *testing.T) {
 	assert.Equal(t, nameSpace, c.DefaultNamespace, "Default namespace should match the one provided")
 }
 
+// TestNewClient_NoApiSuffix tests the creation of a new Backstage client when base URL does not contain /api suffix.
+func TestNewClient_NoApiSuffix(t *testing.T) {
+	const baseURL = "http://localhost:7007"
+
+	c, err := NewClient(baseURL, "", nil)
+
+	assert.NoError(t, err, "New client should not return an error")
+	assert.Equal(t, baseURL+"/api", c.BaseURL.String(), "Base URL should match the one provided")
+	assert.Equal(t, "default", c.DefaultNamespace, "Default namespace should be 'default'")
+}
+
 // TestNewClient tests the creation of a new Backstage client from an existing HTTP client.
 func TestNewClient_ExistingHTTPClient(t *testing.T) {
 	const baseURL = "http://localhost:7007/api"