Skip to content

Commit 6ae3db4

Browse files
committed
review jupyter.Dockerfile
1 parent 977494e commit 6ae3db4

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

docker/jupyter.Dockerfile

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
11
FROM python:3.7
22
RUN apt-get update && apt-get install -y python-dev libffi-dev build-essential
33
WORKDIR /workspace
4-
COPY ./pyproject.toml /workspace
5-
RUN pip3 install poetry
6-
# docker is already a virtual env, no need to create a new one
7-
RUN poetry config virtualenvs.create false
8-
# install poetry minus development packages
9-
RUN poetry install --no-dev
10-
RUN poetry add jupyter
4+
COPY ./setup.py /workspace
5+
RUN pip install .
6+
RUN pip install jupyter
117
EXPOSE 8888
12-
ENTRYPOINT ["poetry", "run", "jupyter", "notebook", "--ip=0.0.0.0", "--port=8888", "--no-browser", "--allow-root"]
8+
ENTRYPOINT ["jupyter", "notebook", "--ip=0.0.0.0", "--port=8888", "--no-browser", "--allow-root"]

0 commit comments

Comments
 (0)