fix(filtering): do not display data labels outside of debug mode

Fix a bug where data labels where being displayed outside of debug mode when another label of the
same task was highlighted

Signed-off-by: Zacharias Fragkiadakis <[email protected]>

Author: QZera

components/ColumnIssueCard.vue

@@ -24,12 +24,32 @@ const status = computed<ColumnCardStatus>(() => ({
 const radicleInterfaceBaseUrl = useRadicleInterfaceBaseUrl()
 const isDebugging = useIsDebugging()
 
+// TODO: zac reduce duplication between ColumnIssueCard and ColumnPatchCard
 const labels = computed(() =>
   isDebugging.value
     ? props.issue.labels
     : props.issue.labels.filter((label) => !label.startsWith(dataLabelNamespace)),
 )
 
+const highlights = computed(() => {
+  if (!props.highlights) {
+    return undefined
+  }
+
+  if (isDebugging.value) {
+    return props.highlights
+  }
+
+  const filteredHighlightLabels = props.highlights.labels.filter(
+    (label) => !(label[0] ?? '').startsWith(dataLabelNamespace),
+  )
+
+  return {
+    ...props.highlights,
+    labels: filteredHighlightLabels,
+  }
+})
+
 const href = computed(() =>
   new URL(
     `/nodes/${route.params.node}/${route.params.rid}/issues/${props.issue.id}`,

components/ColumnPatchCard.vue

@@ -29,12 +29,32 @@ const status = computed<ColumnCardStatus>(() => ({
 const radicleInterfaceBaseUrl = useRadicleInterfaceBaseUrl()
 const isDebugging = useIsDebugging()
 
+// TODO: zac reduce duplication between ColumnIssueCard and ColumnPatchCard
 const labels = computed(() =>
   isDebugging.value
     ? props.patch.labels
     : props.patch.labels.filter((label) => !label.startsWith(dataLabelNamespace)),
 )
 
+const highlights = computed(() => {
+  if (!props.highlights) {
+    return undefined
+  }
+
+  if (isDebugging.value) {
+    return props.highlights
+  }
+
+  const filteredHighlightLabels = props.highlights.labels.filter(
+    (label) => !(label[0] ?? '').startsWith(dataLabelNamespace),
+  )
+
+  return {
+    ...props.highlights,
+    labels: filteredHighlightLabels,
+  }
+})
+
 const href = computed(() =>
   new URL(
     `/nodes/${route.params.node}/${route.params.rid}/patches/${props.patch.id}`,