Skip to content

Commit f768990

Browse files
authored
fix: explicit check for Node.js key import (#1380)
1 parent 001c617 commit f768990

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

factory/.env

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ NODE_VERSION="${FACTORY_DEFAULT_NODE_VERSION}"
1818

1919
# Update the FACTORY_VERSION to deploy cypress/factory if you make changes to
2020
# BASE_IMAGE, FACTORY_DEFAULT_NODE_VERSION, YARN_VERSION, factory.Dockerfile or installScripts
21-
FACTORY_VERSION='5.11.2'
21+
FACTORY_VERSION='5.11.3'
2222

2323
# Chrome versions: https://www.ubuntuupdates.org/package/google_chrome/stable/main/base/google-chrome-stable
2424
# Linux/amd64 only

factory/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Change log
22

3+
## 5.11.3
4+
5+
- Implement PGP key import checks for Node.js and restore the keyserver order to use hkps://keys.openpgp.org first with fallback to keyserver.ubuntu.com. Addressed in [#1380](https://github.com/cypress-io/cypress-docker-images/issues/1380).
6+
37
## 5.11.2
48

59
- Load PGP keys for Node.js from keyserver.ubuntu.com with fallback to hkps://keys.openpgp.org, reversing the previous order. Addresses [#1375](https://github.com/cypress-io/cypress-docker-images/issues/1375) and [#1376](https://github.com/cypress-io/cypress-docker-images/issues/1376).

factory/installScripts/node/default.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ ARCH= && dpkgArch="$(dpkg --print-architecture)" \
3636
A363A499291CBBC940DD62E41F10027AF002F8B0 \
3737
C0D6248439F1D5604AAFFB4021D900FFDB233756 \
3838
; do \
39-
gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$key" || \
40-
gpg --batch --keyserver hkps://keys.openpgp.org $keyserverOptions --recv-keys "$key" ; \
39+
{ gpg --batch --keyserver hkps://keys.openpgp.org $keyserverOptions --recv-keys "$key" && gpg --batch --fingerprint "$key" ; } ||
40+
{ gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$key" && gpg --batch --fingerprint "$key" ; } ; \
4141
done \
4242
&& curl -fsSLO --compressed "https://nodejs.org/dist/v$1/node-v$1-linux-$ARCH.tar.xz" \
4343
&& curl -fsSLO --compressed "https://nodejs.org/dist/v$1/SHASUMS256.txt.asc" \

0 commit comments

Comments
 (0)