Skip to content

Commit a13058f

Browse files
authored
Move unrelated clases from the package with resource operators (strimzi#9882)
Signed-off-by: Jakub Scholz <[email protected]>
1 parent 960d837 commit a13058f

File tree

23 files changed

+68
-67
lines changed

23 files changed

+68
-67
lines changed

cluster-operator/src/main/java/io/strimzi/operator/cluster/ClusterOperatorConfig.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
import io.strimzi.operator.cluster.model.UnsupportedVersionException;
1313
import io.strimzi.operator.common.InvalidConfigurationException;
1414
import io.strimzi.operator.common.Util;
15+
import io.strimzi.operator.common.config.ConfigParameter;
16+
import io.strimzi.operator.common.config.ConfigParameterParser;
1517
import io.strimzi.operator.common.model.Labels;
16-
import io.strimzi.operator.common.operator.resource.ConfigParameter;
17-
import io.strimzi.operator.common.operator.resource.ConfigParameterParser;
1818
import org.apache.logging.log4j.LogManager;
1919
import org.apache.logging.log4j.Logger;
2020

@@ -25,13 +25,13 @@
2525
import java.util.Map;
2626
import java.util.Set;
2727

28-
import static io.strimzi.operator.common.operator.resource.ConfigParameterParser.BOOLEAN;
29-
import static io.strimzi.operator.common.operator.resource.ConfigParameterParser.INTEGER;
30-
import static io.strimzi.operator.common.operator.resource.ConfigParameterParser.LABEL_PREDICATE;
31-
import static io.strimzi.operator.common.operator.resource.ConfigParameterParser.LOCAL_OBJECT_REFERENCE_LIST;
32-
import static io.strimzi.operator.common.operator.resource.ConfigParameterParser.LONG;
33-
import static io.strimzi.operator.common.operator.resource.ConfigParameterParser.NAMESPACE_SET;
34-
import static io.strimzi.operator.common.operator.resource.ConfigParameterParser.STRING;
28+
import static io.strimzi.operator.common.config.ConfigParameterParser.BOOLEAN;
29+
import static io.strimzi.operator.common.config.ConfigParameterParser.INTEGER;
30+
import static io.strimzi.operator.common.config.ConfigParameterParser.LABEL_PREDICATE;
31+
import static io.strimzi.operator.common.config.ConfigParameterParser.LOCAL_OBJECT_REFERENCE_LIST;
32+
import static io.strimzi.operator.common.config.ConfigParameterParser.LONG;
33+
import static io.strimzi.operator.common.config.ConfigParameterParser.NAMESPACE_SET;
34+
import static io.strimzi.operator.common.config.ConfigParameterParser.STRING;
3535

3636
/**
3737
* Cluster Operator configuration
@@ -136,7 +136,7 @@ public class ClusterOperatorConfig {
136136
/**
137137
* Namespace in which the operator will run and create resources
138138
*/
139-
public static final ConfigParameter<Set<String>> NAMESPACE = new ConfigParameter<>("STRIMZI_NAMESPACE", NAMESPACE_SET, "*", CONFIG_VALUES);
139+
public static final ConfigParameter<Set<String>> NAMESPACE = new ConfigParameter<>("STRIMZI_NAMESPACE", NAMESPACE_SET, ConfigParameter.ANY_NAMESPACE, CONFIG_VALUES);
140140

141141
/**
142142
* Specify every how many milliseconds the reconciliation runs

cluster-operator/src/main/java/io/strimzi/operator/cluster/leaderelection/LeaderElectionManagerConfig.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@
44
*/
55
package io.strimzi.operator.cluster.leaderelection;
66

7-
import io.strimzi.operator.common.operator.resource.ConfigParameter;
7+
import io.strimzi.operator.common.config.ConfigParameter;
88

99
import java.time.Duration;
1010
import java.util.Collections;
1111
import java.util.HashMap;
1212
import java.util.Map;
1313
import java.util.Set;
1414

15-
import static io.strimzi.operator.common.operator.resource.ConfigParameterParser.DURATION;
16-
import static io.strimzi.operator.common.operator.resource.ConfigParameterParser.NON_EMPTY_STRING;
15+
import static io.strimzi.operator.common.config.ConfigParameterParser.DURATION;
16+
import static io.strimzi.operator.common.config.ConfigParameterParser.NON_EMPTY_STRING;
1717

1818
/**
1919
* Configuration class for the Leader Election Manager

cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/AbstractOperator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import io.strimzi.operator.common.Reconciliation;
2121
import io.strimzi.operator.common.ReconciliationException;
2222
import io.strimzi.operator.common.ReconciliationLogger;
23+
import io.strimzi.operator.common.TimeoutException;
2324
import io.strimzi.operator.common.Util;
2425
import io.strimzi.operator.common.VertxUtil;
2526
import io.strimzi.operator.common.metrics.OperatorMetricsHolder;
@@ -30,7 +31,6 @@
3031
import io.strimzi.operator.common.model.StatusDiff;
3132
import io.strimzi.operator.common.model.StatusUtils;
3233
import io.strimzi.operator.common.operator.resource.AbstractWatchableStatusedNamespacedResourceOperator;
33-
import io.strimzi.operator.common.operator.resource.TimeoutException;
3434
import io.vertx.core.AsyncResult;
3535
import io.vertx.core.Future;
3636
import io.vertx.core.Handler;

cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/ConnectOperatorMetricsHolder.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import io.micrometer.core.instrument.Timer;
99
import io.strimzi.api.kafka.model.connector.KafkaConnector;
1010
import io.strimzi.operator.common.MetricsProvider;
11+
import io.strimzi.operator.common.config.ConfigParameter;
1112
import io.strimzi.operator.common.metrics.OperatorMetricsHolder;
1213
import io.strimzi.operator.common.model.Labels;
1314

@@ -133,7 +134,7 @@ public Timer connectorsReconciliationsTimer(String namespace) {
133134
* @param namespace Namespace for which should the metrics be reset to 0
134135
*/
135136
public void resetConnectorsCounters(String namespace) {
136-
if (namespace.equals("*")) {
137+
if (namespace.equals(ConfigParameter.ANY_NAMESPACE)) {
137138
connectorsResourceCounterMap.forEach((key, counter) -> counter.set(0));
138139
pausedConnectorsResourceCounterMap.forEach((key, counter) -> counter.set(0));
139140
} else {

cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/Operator.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
import io.fabric8.kubernetes.api.model.LabelSelector;
88
import io.strimzi.operator.common.Reconciliation;
9+
import io.strimzi.operator.common.config.ConfigParameter;
910
import io.strimzi.operator.common.metrics.OperatorMetricsHolder;
1011
import io.strimzi.operator.common.model.NamespaceAndName;
1112
import io.vertx.core.AsyncResult;
@@ -73,7 +74,7 @@ default void reconcileAll(String trigger, String namespace, Handler<AsyncResult<
7374
* @param handler Handler called on completion.
7475
*/
7576
default void reconcileThese(String trigger, Set<NamespaceAndName> desiredNames, String namespace, Handler<AsyncResult<Void>> handler) {
76-
if (namespace.equals("*")) {
77+
if (namespace.equals(ConfigParameter.ANY_NAMESPACE)) {
7778
metrics().resetResourceAndPausedResourceCounters();
7879
} else {
7980
metrics().resourceCounter(namespace).set(0);

cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/resource/KafkaRoller.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ private Future<Void> schedule(NodeRef nodeRef, long delay, TimeUnit unit) {
390390
LOGGER.infoCr(reconciliation, "Could not verify pod {} is up-to-date, giving up after {} attempts. Total delay between attempts {}ms",
391391
nodeRef, ctx.backOff.maxAttempts(), ctx.backOff.totalDelayMs(), e);
392392
ctx.promise.fail(e instanceof TimeoutException ?
393-
new io.strimzi.operator.common.operator.resource.TimeoutException() :
393+
new io.strimzi.operator.common.TimeoutException() :
394394
e);
395395
} else {
396396
long delay1 = ctx.backOff.delayMs();

cluster-operator/src/test/java/io/strimzi/operator/cluster/operator/assembly/ZooKeeperEraserTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import io.strimzi.operator.cluster.operator.resource.ResourceOperatorSupplier;
2424
import io.strimzi.operator.common.Annotations;
2525
import io.strimzi.operator.common.Reconciliation;
26+
import io.strimzi.operator.common.TimeoutException;
2627
import io.strimzi.operator.common.model.Labels;
2728
import io.strimzi.operator.common.operator.resource.ConfigMapOperator;
2829
import io.strimzi.operator.common.operator.resource.NetworkPolicyOperator;
@@ -32,7 +33,6 @@
3233
import io.strimzi.operator.common.operator.resource.ServiceAccountOperator;
3334
import io.strimzi.operator.common.operator.resource.ServiceOperator;
3435
import io.strimzi.operator.common.operator.resource.StrimziPodSetOperator;
35-
import io.strimzi.operator.common.operator.resource.TimeoutException;
3636
import io.vertx.core.Future;
3737
import io.vertx.junit5.Checkpoint;
3838
import io.vertx.junit5.VertxExtension;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Copyright Strimzi authors.
33
* License: Apache License 2.0 (see the file LICENSE or http://apache.org/licenses/LICENSE-2.0.html).
44
*/
5-
package io.strimzi.operator.common.operator.resource;
5+
package io.strimzi.operator.common;
66

77
/**
88
* Thrown to indicate that timeout has been exceeded.

operator-common/src/main/java/io/strimzi/operator/common/VertxUtil.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import io.strimzi.api.kafka.model.common.authentication.KafkaClientAuthenticationTls;
1515
import io.strimzi.certs.CertAndKey;
1616
import io.strimzi.operator.common.operator.resource.SecretOperator;
17-
import io.strimzi.operator.common.operator.resource.TimeoutException;
1817
import io.vertx.core.Future;
1918
import io.vertx.core.Handler;
2019
import io.vertx.core.Promise;
Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Copyright Strimzi authors.
33
* License: Apache License 2.0 (see the file LICENSE or http://apache.org/licenses/LICENSE-2.0.html).
44
*/
5-
package io.strimzi.operator.common.operator.resource;
5+
package io.strimzi.operator.common.config;
66

77
import io.strimzi.operator.common.InvalidConfigurationException;
88

@@ -22,6 +22,11 @@
2222
* @param map Map that will contain all the configuration values
2323
*/
2424
public record ConfigParameter<T>(String key, ConfigParameterParser<T> type, String defaultValue, boolean required, Map<String, ConfigParameter<?>> map) {
25+
/**
26+
* Marker for indication "all namespaces" => this is used for example when creating watches to create a cluster
27+
* wide watch.
28+
*/
29+
public final static String ANY_NAMESPACE = "*";
2530

2631
/**
2732
* Constructor

0 commit comments

Comments
 (0)