Skip to content

Revert "feat(nginx): use slice module" #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

ChandonPierre
Copy link

This reverts commit 9cd0135.

This seems to cause more problems than it solves -

< X-Docker-Registry-Proxy-Cache-Upstream-Status: HIT
< X-Docker-Registry-Proxy-Cache-Type: manifest-secondary
< Accept-Ranges: bytes
< 
* transfer closed with 1609 bytes remaining to read
* Closing connection 0
* TLSv1.3 (OUT), TLS alert, close notify (256):
curl: (18) transfer closed with 1609 bytes remaining to read

Since cache key is defined in common, slice module applies to manifests as well, which seems to lead to unexpected EOF pulling image manifests on occasion

@ChandonPierre ChandonPierre merged commit 2946e54 into coreweave Dec 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant