Skip to content

instruments: open_telemetry: port auto_instrumentation #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

danberdev
Copy link
Member

  • auto_instrumentation.initialize() uses a distro for loading instrumentation. This overrides some needed defaults, that we use in our loader. E.g. it starts exporting telemetry somewhere undesirable. So these changes port the loader to our infrastructure.

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 98.88% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...obootstrap/instruments/opentelemetry_instrument.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danberdev danberdev force-pushed the feature/port-auto-instrumentalization branch 12 times, most recently from da6e044 to 6e9c62a Compare June 30, 2025 14:57
@danberdev danberdev changed the title WIP: DO NOT MERGE instruments: open_telemetry: port auto_instrumentation instruments: open_telemetry: port auto_instrumentation Jun 30, 2025
@danberdev danberdev force-pushed the feature/port-auto-instrumentalization branch from 6e9c62a to c5a4cfe Compare June 30, 2025 14:58
@danberdev
Copy link
Member Author

@vrslev could you take a look, please?

Copy link
Contributor

@vrslev vrslev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing from my phone, so may have missed something. I will take another look tomorrow 🙂

Copy link
Contributor

@vrslev vrslev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, reviewed fully

@danberdev danberdev force-pushed the feature/port-auto-instrumentalization branch 5 times, most recently from 3e4e41d to 9f8627e Compare July 1, 2025 05:36
- auto_instrumentation.initialize() uses a distro for loading instrumentation. This overrides some
needed defaults, that we use in our loader. E.g. it starts exporting telemetry somewhere
undesirable. So these changes port the loader to our infrastructure.
@danberdev danberdev force-pushed the feature/port-auto-instrumentalization branch from 9f8627e to e51605a Compare July 1, 2025 05:43
Copy link
Contributor

@vrslev vrslev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now. Let’s also wait for review from @insani7y

@insani7y
Copy link
Member

insani7y commented Jul 1, 2025

LGTM

@insani7y insani7y merged commit bc92ffc into main Jul 1, 2025
15 checks passed
@insani7y insani7y deleted the feature/port-auto-instrumentalization branch July 1, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants