Skip to content

Added the ui pipeline of the web #18736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2025
Merged

Added the ui pipeline of the web #18736

merged 5 commits into from
May 29, 2025

Conversation

GengineJS
Copy link
Contributor

No description provided.

@GengineJS GengineJS requested a review from star-e May 26, 2025 02:29
if (cameraConfigs.enableProfiler) {
flags |= rendering.SceneFlags.PROFILER;
prevRenderPass.showStatistics = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is still needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK,For compatibility considerations?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If pass.showStatistics is false, the profiler should not be rendered for now.

let flags = SceneFlags.BLEND | SceneFlags.UI;
const flags = SceneFlags.BLEND | SceneFlags.UI;
const queue = pass.addQueue(QueueHint.BLEND);
queue.addScene(camera, flags);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here might change to

queue.addScene(camera, SceneFlags.BLEND);
queue.addDraw2D(camera);

Copy link

github-actions bot commented May 26, 2025

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1005977 bytes 1005977 bytes ✅ 0 bytes
2D All (legacy pipeline) 2671042 bytes 2671042 bytes ✅ 0 bytes
2D All (new pipeline) 2760514 bytes 2760494 bytes 👍 -20 bytes
(2D + 3D) All 10016452 bytes 10016432 bytes 👍 -20 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16838073 bytes 16838053 bytes 👍 -20 bytes

Interface Check Report

This pull request does not change any public interfaces !

@GengineJS GengineJS requested a review from star-e May 26, 2025 07:44
@star-e
Copy link
Contributor

star-e commented May 26, 2025

@cocos-robot run-test-cases-custom

@star-e
Copy link
Contributor

star-e commented May 26, 2025

@cocos-robot run test cases

5 similar comments
@sushanhong
Copy link
Contributor

@cocos-robot run test cases

@SQ-cai
Copy link
Contributor

SQ-cai commented May 27, 2025

@cocos-robot run test cases

@sushanhong
Copy link
Contributor

@cocos-robot run test cases

@sushanhong
Copy link
Contributor

@cocos-robot run test cases

@sushanhong
Copy link
Contributor

@cocos-robot run test cases

Copy link

@GengineJS, Please check the result of run test cases:

Task Details

Copy link

@GengineJS, Please check the result of run test cases:

Task Details

@sushanhong
Copy link
Contributor

@cocos-robot run test cases

Copy link

@GengineJS, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL event-first,event-info,dynamic-tiled-map,bytecode,label-attribute-switch,scroll-view-scroll-to-offset
ios PASS PASS FAIL 2d-rendering-in-3d,atlas-compress,modelPriority,AnimationEvent,EasingMethods,Morph,SwitchAnimation,load-atlas-texture,test-js-list,event-first,planar-shadow,shadowBias,shield-node,particle-rotation,rt-read-pixels,cameraUseRenderTex,canvasUseRenderTex,bytecode,deprecated,CoreJsTest,terrain,tween-clone,tween-parallel,tween-removeself,tween-repeat,tween-show-hide,tween-stop,filter,simple,sliced-sprite,label-attribute-switch,sprite-grayscale,trimmed,bmfont,button-click,click-when-scroll,anim-widget,layout-basic-grid,layout-basic-horizontal,scroll-view-scroll-to-offset,rich-text-event,graphics-mask,mask-inverted,mask,slider,progress,graphics,pageView_free_horizontal,pageView_free_verticle,coordinate-ui-3d,visibility-changed
mac PASS PASS FAIL EasingMethods,Morph,SwitchAnimation,event-first,event-info,planar-shadow,shield-node,particle-rotation,capture_to_web,bytecode,terrain,label-attribute-switch,bmfont,click-when-scroll,coordinate-ui-3d,visibility-changed

Copy link

@GengineJS, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL 2d-rendering-in-3d,Morph,SwitchAnimation,event-first,geometry-renderer,planar-shadow,dynamic-tiled-map,shield-node,particle-culling,particle-rotation,capture_to_web,raycast-mesh&model,bytecode,sprite-attribute-switch,label-attribute-switch,bmfont,label-cacheMode-color,scroll-view-scroll-to-offset,pageView_free_horizontal,coordinate-ui-3d,visibility-changed
android PASS PASS FAIL 2d-rendering-in-3d,modelPriority,AnimationEvent,Morph,PartAnimation,SwitchAnimation,image-importer,load-atlas-texture,test-js-list,audioBuffer,dynamic-mesh,event-first,multiTouch,planar-shadow,shadowBias,localization,material,DragonBonesAttach,SpineBoy,dynamic-tiled-map,shield-node,particle-color,particle-limit-velocity,particle-rotation,particle-velocity,rt-read-pixels,render-ui-to-spriteframe,cameraUseRenderTex,use-render-texture-asset,camera,hdr-ldr,raycast,bytecode,CoreJsTest,terrain,tween-clone,tween-parallel,tween-removeself,tween-repeat-forever,tween-repeat,tween-show-hide,tween-stop,tween-then,tween,fill-sprite,filter,simple,sliced-sprite,label-attribute-switch,sprite-grayscale,trimmed,bmfont,button-click,anim-widget,widget-destroy,layout-scrollview,layout-size-changed,list-view,scroll-view-bounce-back,scroll-view-rotation,scroll-view-scroll-to-offset,rich-text-event,graphics-mask,mask-inverted,mask-migrate,mask-nesting,slider,progress,graphics-continuous-filling,graphics-draw-before-init,graphics,pageView_free_horizontal,coordinate-ui-3d,particle-2d-color,particle-2d-position-type-change,opacity-multi-canvas,visibility-changed
wechatgame PASS PASS FAIL event-first,label-attribute-switch,scroll-view-scroll-to-offset

@sushanhong
Copy link
Contributor

@cocos-robot run test cases

Copy link

@GengineJS, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL event-first,event-info,dynamic-tiled-map,bytecode,label-attribute-switch,scroll-view-scroll-to-offset
ios PASS PASS FAIL 2d-rendering-in-3d,atlas-compress,modelPriority,AnimationEvent,EasingMethods,Morph,SwitchAnimation,load-atlas-texture,test-js-list,event-first,planar-shadow,shadowBias,shield-node,particle-rotation,rt-read-pixels,cameraUseRenderTex,canvasUseRenderTex,bytecode,deprecated,CoreJsTest,terrain,tween-clone,tween-parallel,tween-removeself,tween-repeat,tween-show-hide,tween-stop,filter,simple,sliced-sprite,label-attribute-switch,sprite-grayscale,trimmed,bmfont,button-click,click-when-scroll,anim-widget,layout-basic-grid,layout-basic-horizontal,scroll-view-scroll-to-offset,rich-text-event,graphics-mask,mask-inverted,mask,slider,progress,graphics,pageView_free_horizontal,pageView_free_verticle,coordinate-ui-3d,visibility-changed
mac PASS PASS FAIL EasingMethods,Morph,SwitchAnimation,event-first,event-info,planar-shadow,shield-node,particle-rotation,capture_to_web,bytecode,terrain,label-attribute-switch,bmfont,click-when-scroll,coordinate-ui-3d,visibility-changed

Copy link

@GengineJS, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL 2d-rendering-in-3d,Morph,SwitchAnimation,event-first,geometry-renderer,planar-shadow,dynamic-tiled-map,shield-node,particle-culling,particle-rotation,capture_to_web,raycast-mesh&model,bytecode,sprite-attribute-switch,label-attribute-switch,bmfont,label-cacheMode-color,scroll-view-scroll-to-offset,pageView_free_horizontal,coordinate-ui-3d,visibility-changed
android PASS PASS FAIL 2d-rendering-in-3d,modelPriority,AnimationEvent,Morph,PartAnimation,SwitchAnimation,image-importer,load-atlas-texture,test-js-list,audioBuffer,dynamic-mesh,event-first,multiTouch,planar-shadow,shadowBias,localization,material,DragonBonesAttach,SpineBoy,dynamic-tiled-map,shield-node,particle-color,particle-limit-velocity,particle-rotation,particle-velocity,rt-read-pixels,render-ui-to-spriteframe,cameraUseRenderTex,use-render-texture-asset,camera,hdr-ldr,raycast,bytecode,CoreJsTest,terrain,tween-clone,tween-parallel,tween-removeself,tween-repeat-forever,tween-repeat,tween-show-hide,tween-stop,tween-then,tween,fill-sprite,filter,simple,sliced-sprite,label-attribute-switch,sprite-grayscale,trimmed,bmfont,button-click,anim-widget,widget-destroy,layout-scrollview,layout-size-changed,list-view,scroll-view-bounce-back,scroll-view-rotation,scroll-view-scroll-to-offset,rich-text-event,graphics-mask,mask-inverted,mask-migrate,mask-nesting,slider,progress,graphics-continuous-filling,graphics-draw-before-init,graphics,pageView_free_horizontal,coordinate-ui-3d,particle-2d-color,particle-2d-position-type-change,opacity-multi-canvas,visibility-changed
wechatgame PASS PASS FAIL event-first,label-attribute-switch,scroll-view-scroll-to-offset

@sushanhong
Copy link
Contributor

@cocos-robot run-test-cases-custom

Copy link

@GengineJS, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL particles-noise-test,scroll-view-scroll-to-offset,mask-type-change
ios PASS PASS FAIL particles-noise-test
mac PASS PASS FAIL event-info,particles-noise-test

Copy link

@GengineJS, Please check the result of run test cases:

Task Details

@star-e
Copy link
Contributor

star-e commented May 28, 2025

@cocos-robot run-test-cases-custom

@star-e star-e closed this May 29, 2025
@star-e star-e reopened this May 29, 2025
@star-e
Copy link
Contributor

star-e commented May 29, 2025

@cocos-robot run-test-cases-custom

Copy link

@GengineJS, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL bloom,LoadRes
ios PASS PASS FAIL bloom
mac PASS PASS FAIL bloom

Copy link

@GengineJS, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL bloom
android PASS PASS RUNNING touch-event bloom
wechatgame PASS PASS FAIL bloom

@star-e star-e merged commit a3ac043 into cocos:v3.8.7 May 29, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants