Fix duplicate rendering issue caused by failure to restore ibCount during batch merging #18721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring batch merging
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
star-e
reviewed
May 19, 2025
| @@ -429,10 +428,10 @@ CC_FORCE_INLINE void Batcher2d::handleMiddlewareDraw(RenderEntity* entity, Rende | |||
| // check for merge draw | |||
| auto enableBatch = !entity->getUseLocal(); | |||
| if (enableBatch && _currTexture == texture && _currMeshBuffer == meshBuffer && !_currEntity->getUseLocal() && material->getHash() == _currMaterial->getHash() && drawInfo->getIndexOffset() == _currDrawInfo->getIndexOffset() + _currDrawInfo->getIbCount() && layer == _currLayer) { | |||
| auto ibCount = _currDrawInfo->getIbCount(); | |||
| _currDrawInfo->setIbCount(ibCount + drawInfo->getIbCount()); | |||
| _currMiddlewareIbCount += drawInfo->getIbCount(); | |||
There was a problem hiding this comment.
What will happen if handleMiddlewareDraw is called multiple times with the same object?
There was a problem hiding this comment.
It will cause duplicate rendering because the ibCount inside _currDrawInfo has been changed, but there is no place to revert the setting
There was a problem hiding this comment.
I think duplicated rendering is acceptable. The program is correct, right?
There was a problem hiding this comment.
This will cause the shaded portion to be incorrect. #18704
|
@cocos-robot run test cases |
star-e
approved these changes
May 19, 2025
|
@qiuguohua, Please check the result of
Task Details
|
|
@qiuguohua, Please check the result of
Task Details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
#18704
Continuous Integration
This pull request:
Compatibility Check
This pull request: