Fix crashes while calling setSlotTexture or running at cache mode

Author: bofeng-song

native/cocos/editor-support/spine-creator-support/SkeletonCache.cpp

@@ -30,10 +30,14 @@
 #include "SkeletonCache.h"
 #include "base/memory/Memory.h"
 #include "spine-creator-support/AttachmentVertices.h"
+#include "SkeletonDataMgr.h"
 
 USING_NS_MW;        // NOLINT(google-build-using-namespace)
 using namespace cc; // NOLINT(google-build-using-namespace)
 using namespace spine;
+
+extern "C" AttachmentVertices *generateAttachmentVertices(Attachment *attachment);
+
 namespace cc {
 
 float SkeletonCache::FrameTime = 1.0F / 60.0F;
@@ -311,6 +315,10 @@ void SkeletonCache::renderAnimationFrame(AnimationData *animationData) {
         matm[13] = bone->getWorldY();
     }
 
+
+    auto *verticesMap = SkeletonDataMgr::getInstance()->getSkeletonDataInfo(_uuid);
+    if (!verticesMap) return;
+    auto &attachmentVerticesMap = *verticesMap;
     auto &drawOrder = _skeleton->getDrawOrder();
     for (size_t i = 0, n = drawOrder.size(); i < n; ++i) {
         slot = drawOrder[i];
@@ -319,20 +327,34 @@ void SkeletonCache::renderAnimationFrame(AnimationData *animationData) {
             continue;
         }
 
-        if (!slot->getAttachment()) {
+        auto *tmpAttachment = slot->getAttachment();
+        if (!tmpAttachment) {
             _clipper->clipEnd(*slot);
             continue;
         }
         const spine::Color &slotColor = slot->getColor();
 
+        auto iterAttachment = attachmentVerticesMap.find(tmpAttachment);
+        if (iterAttachment != attachmentVerticesMap.end()) {
+            attachmentVertices = iterAttachment->second;
+        } else {
+            attachmentVertices = nullptr;
+        }
+
         TwoColorTriangles trianglesTwoColor;
         spine::Color attachmentColor;
-        if (slot->getAttachment()->getRTTI().isExactly(RegionAttachment::rtti)) {
-            auto *attachment = dynamic_cast<RegionAttachment *>(slot->getAttachment());
-#if CC_USE_SPINE_3_8
-            attachmentVertices = static_cast<AttachmentVertices *>(attachment->getRendererObject());
-#else
-            attachmentVertices = static_cast<AttachmentVertices *>(attachment->getRegion()->rendererObject);
+        if (tmpAttachment->getRTTI().isExactly(RegionAttachment::rtti)) {
+            auto *attachment = dynamic_cast<RegionAttachment *>(tmpAttachment);
+#if CC_USE_SPINE_4_2
+            if (!attachment->getRegion()) {
+                attachment->getSequence()->apply(slot, attachment);
+                if (attachment->getRegion()) {
+                    attachmentVertices = generateAttachmentVertices(attachment);
+                    if (attachmentVertices) {
+                        attachmentVerticesMap[attachment] = attachmentVertices;
+                    }
+                }
+            }
 #endif
 
             // Early exit if attachment is invisible
@@ -362,12 +384,18 @@ void SkeletonCache::renderAnimationFrame(AnimationData *animationData) {
 
             attachmentColor = attachment->getColor();
 
-        } else if (slot->getAttachment()->getRTTI().isExactly(MeshAttachment::rtti)) {
-            auto *attachment = dynamic_cast<MeshAttachment *>(slot->getAttachment());
-#if CC_USE_SPINE_3_8
-            attachmentVertices = static_cast<AttachmentVertices *>(attachment->getRendererObject());
-#else
-            attachmentVertices = static_cast<AttachmentVertices *>(attachment->getRegion()->rendererObject);
+        } else if (tmpAttachment->getRTTI().isExactly(MeshAttachment::rtti)) {
+            auto *attachment = dynamic_cast<MeshAttachment *>(tmpAttachment);
+#if CC_USE_SPINE_4_2
+            if (!attachment->getRegion()) {
+                attachment->getSequence()->apply(slot, attachment);
+                if (attachment->getRegion()) {
+                    attachmentVertices = generateAttachmentVertices(attachment);
+                    if (attachmentVertices) {
+                        attachmentVerticesMap[attachment] = attachmentVertices;
+                    }
+                }
+            }
 #endif
 
             // Early exit if attachment is invisible
@@ -391,8 +419,8 @@ void SkeletonCache::renderAnimationFrame(AnimationData *animationData) {
             trianglesTwoColor.indices = reinterpret_cast<uint16_t *>(ib.getCurBuffer());
             memcpy(trianglesTwoColor.indices, attachmentVertices->_triangles->indices, ibSize);
             attachmentColor = attachment->getColor();
-        } else if (slot->getAttachment()->getRTTI().isExactly(ClippingAttachment::rtti)) {
-            auto *clip = dynamic_cast<ClippingAttachment *>(slot->getAttachment());
+        } else if (tmpAttachment->getRTTI().isExactly(ClippingAttachment::rtti)) {
+            auto *clip = dynamic_cast<ClippingAttachment *>(tmpAttachment);
             _clipper->clipStart(*slot, clip);
             continue;
         } else {

native/cocos/editor-support/spine-creator-support/SkeletonRenderer.cpp

@@ -65,14 +65,6 @@ enum DebugType {
     BONES
 };
 
-template<typename VertexType, typename UVArrayType>
-void loopUVCoords(VertexType* tmp, const UVArrayType& uvs, int count) {
-    for (int i = 0, ii = 0; i < count; ++i, ii += 2) {
-        tmp[i].texCoord.u = uvs[ii];
-        tmp[i].texCoord.v = uvs[ii + 1];
-    }
-}
-
 extern "C" AttachmentVertices *generateAttachmentVertices(Attachment *attachment);
 namespace cc {
 SkeletonRenderer *SkeletonRenderer::create() {
@@ -1168,12 +1160,15 @@ void SkeletonRenderer::setSlotTexture(const std::string &slotName, cc::Texture2D
     if (!attachment) return;
     auto width = tex2d->getWidth();
     auto height = tex2d->getHeight();
+    auto *verticesMap = SkeletonDataMgr::getInstance()->getSkeletonDataInfo(_uuid);
+    if (!verticesMap) return;
+    auto &attachmentVerticesMap = *verticesMap;
+    auto *attachmentVertices = attachmentVerticesMap.at(attachment);
 
     if (createAttachment) {
         attachment = attachment->copy();
     }
     SlotCacheInfo slotCacheInfo{createAttachment, attachment, nullptr};
-    AttachmentVertices *attachmentVertices = nullptr;
     if (attachment->getRTTI().isExactly(spine::RegionAttachment::rtti)) {
         auto region = static_cast<RegionAttachment *>(attachment);
 #if CC_USE_SPINE_3_8
@@ -1185,7 +1180,6 @@ void SkeletonRenderer::setSlotTexture(const std::string &slotName, cc::Texture2D
         region->setHeight(height);
         region->setUVs(0, 0, 1.0f, 1.0f, false);
         region->updateOffset();
-        attachmentVertices = static_cast<AttachmentVertices *>(region->getRendererObject());
         if (createAttachment) {
             attachmentVertices = attachmentVertices->copy();
             slotCacheInfo.attachmentVertices = attachmentVertices;
@@ -1215,8 +1209,6 @@ void SkeletonRenderer::setSlotTexture(const std::string &slotName, cc::Texture2D
         uvs[0] = 1;
         uvs[1] = 1;
         region->updateRegion();
-        auto *tmpMap = static_cast<spine::HashMap<Attachment *, AttachmentVertices *> *>(textureRegion->rendererObject);
-        attachmentVertices = (*tmpMap)[slot->getAttachment()];
         if (createAttachment) {
             attachmentVertices = attachmentVertices->copy();
             slotCacheInfo.attachmentVertices = attachmentVertices;
@@ -1244,7 +1236,6 @@ void SkeletonRenderer::setSlotTexture(const std::string &slotName, cc::Texture2D
         mesh->setRegionRotate(true);
         mesh->setRegionDegrees(0);
         mesh->updateUVs();
-        attachmentVertices = static_cast<AttachmentVertices *>(mesh->getRendererObject());
         if (createAttachment) {
             attachmentVertices = attachmentVertices->copy();
             slotCacheInfo.attachmentVertices = attachmentVertices;
@@ -1265,8 +1256,6 @@ void SkeletonRenderer::setSlotTexture(const std::string &slotName, cc::Texture2D
         mesh->setWidth(width);
         mesh->setHeight(height);
         mesh->updateRegion();
-        auto *tmpMap = static_cast<spine::HashMap<Attachment *, AttachmentVertices *> *>(mesh->getRegion()->rendererObject);
-        attachmentVertices = (*tmpMap)[slot->getAttachment()];
         if (createAttachment) {
             attachmentVertices = attachmentVertices->copy();
             slotCacheInfo.attachmentVertices = attachmentVertices;

native/cocos/editor-support/spine-creator-support/SkeletonRenderer.h

@@ -50,6 +50,15 @@ class Material;
 
 class AttachmentVertices;
 
+
+template <typename VertexType, typename UVArrayType>
+void loopUVCoords(VertexType *tmp, const UVArrayType &uvs, int count) {
+    for (int i = 0, ii = 0; i < count; ++i, ii += 2) {
+        tmp[i].texCoord.u = uvs[ii];
+        tmp[i].texCoord.v = uvs[ii + 1];
+    }
+}
+
 struct SlotCacheInfo {
     bool isOwner{false};
     spine::Attachment *attachment{nullptr};