Skip to content

wallet_restore_page: Credentials supplied to restored wallets have a path with random basename. #2243

Open
@JoeGruffins

Description

@JoeGruffins
Contributor

Describe the bug
Restored wallets are not supplied a dirPath that uses the wallet name. Being a random name, this may cause trouble if two are randomly the same. The dirPath is not visible to the user anywhere. It is probably intended for the dirPath to use the name.

To Reproduce

  1. Put some prints in to see what values are return when doing any restoreFromSeed
  2. Restore a wallet.
  3. Compare credentials.walletInfo!.dirPath and credentials.walletInfo!.path to the wallet name.

Expected behavior
dirPath is created from the coin dir and the wallet name.

Platform:

  • all

Additional context
A simple change fixes for newer wallets, but unsure if this is causing unintended bugs elsewhere that should also be fixed at the same time. JoeGruffins@6cd8259

Activity

changed the title [-]wallet_restore_page: Credentials supplied to restored wallets have a path with random base name.[/-] [+]wallet_restore_page: Credentials supplied to restored wallets have a path with random basename.[/+] on May 1, 2025
JoeGruffins

JoeGruffins commented on May 2, 2025

@JoeGruffins
ContributorAuthor

This is probably mostly a problem for ios, since it seems the directory moves between updates, so you could only find the previous directory using the stored basename of the dirPath, not the current name of the wallet as we were doing in decred. This caused a bug where the internal wallet just disappeared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @JoeGruffins

        Issue actions

          wallet_restore_page: Credentials supplied to restored wallets have a path with random basename. · Issue #2243 · cake-tech/cake_wallet